Bug 354654 – forgets to escape markup somewhere

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 354654 - forgets to escape markup somewhere


Summary:	forgets to escape markup somewhere


Status:	RESOLVED FIXED

Product:	alacarte
Classification:	Applications
Component:	general
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Alacarte Maintainer(s)
QA Contact:	Alacarte Maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2006-09-06 16:54 UTC by Matthias Clasen
Modified:	2006-10-02 23:41 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Matthias Clasen 2006-09-06 16:54:27 UTC

when bringing up the Properties dialog for "Menus & Toolbars", I see

/usr/lib/python2.4/site-packages/Alacarte/DialogHandler.py:244: GtkWarning: Failed to set text from markup due to error parsing markup: Error on line 1: Character ' ' is not valid at the start of an entity name; the & character begins an entity; if this ampersand isn't supposed to be an entity, escape it as &amp;
  self.item_row[2] = self.tree.get_widget('item_name_entry').get_text()
/usr/lib/python2.4/site-packages/Alacarte/DialogHandler.py:243: GtkWarning: Failed to set text from markup due to error parsing markup: Error on line 1: Character ' ' is not valid at the start of an entity name; the & character begins an entity; if this ampersand isn't supposed to be an entity, escape it as &amp;
  self.item_row[1] = util.getIcon(self.tree.get_widget('item_icon_button').icon_path)
/usr/lib/python2.4/site-packages/Alacarte/DialogHandler.py:237: GtkWarning: Failed to set text from markup due to error parsing markup: Error on line 1: Character ' ' is not valid at the start of an entity name; the & character begins an entity; if this ampersand isn't supposed to be an entity, escape it as &amp;
  response = dialog.run()

Comment 1 Matthias Clasen 2006-09-06 16:57:13 UTC

oh, and after I close that dialog, and try to move the item with the "Move"
buttons, I get 

Traceback (most recent call last):

+ Trace 71744

File "/usr/lib/python2.4/site-packages/Alacarte/MainWindow.py", line 495 in on_move_up_button_clicked
```
self.editor.moveItem(item, item.get_parent(), before=before)
```
File "/usr/lib/python2.4/site-packages/Alacarte/MenuEditor.py", line 296 in moveItem
```
self.__positionItem(new_parent, item, before, after)
```
File "/usr/lib/python2.4/site-packages/Alacarte/MenuEditor.py", line 662 in __positionItem
```
menu_xml = self.__getXmlMenu(self.__getPath(parent), dom, dom)
```
File "/usr/lib/python2.4/site-packages/Alacarte/MenuEditor.py", line 475 in __getXmlMenu
```
node = self.__addXmlMenuElement(element, name, dom)
```
File "/usr/lib/python2.4/site-packages/Alacarte/MenuEditor.py", line 486 in __addXmlMenuElement
```
return element.appendChild(node)
```

File "/usr/lib/python2.4/site-packages/_xmlplus/dom/minidom.py", line 1548 in appendChild

raise xml.dom.HierarchyRequestErr( xml.dom.HierarchyRequestErr: two document elements disallowed

Comment 2 Travis Watkins 2006-10-02 23:41:07 UTC

This _should_ be fixed.