GNOME Bugzilla – Bug 354650
Reply with blank line selected truncates text
Last modified: 2013-09-10 14:04:39 UTC
Please describe the problem: When you reply to a message with a blank line selected (double-click on a blank line, for example), the reply comes up with nothing but the attribute line. This is arguably what the user wanted, but it most often happens by accident, and (since selected blank lines don't show up highlighted), there's not feedback as to what's causing the problem. Talking this over on IRC, several of us came to the conclusion that this is probably not the correct behavor. Attached is a patch that fixes this, by ignoring empty selections. Steps to reproduce: 1. In the preview mode, double click on a blank line 2. reply to the message Actual results: Reply is empty except for attribution line. Expected results: Reply contains full message text. Does this happen every time? Yes. Other information:
Created attachment 72333 [details] [review] Check for blank selection when replying Check the selection to make sure it's not empty before using it in the reply.
*** Bug 354976 has been marked as a duplicate of this bug. ***
patch! :-)
*** Bug 358145 has been marked as a duplicate of this bug. ***
Patch looks good. Please commit with a changelog.
Just for the record: I don't have gnome commit (yet?), so someone else will have to commit this...
committed to CVS HEAD ans gnome-2-14 branch on behalf of daniel: http://cvs.gnome.org/viewcvs/evolution/mail/em-folder-view.c?r1=1.161&r2=1.162 http://cvs.gnome.org/viewcvs/evolution/mail/em-folder-view.c?r1=1.145.2.1&r2=1.145.2.2 patch will be included in evolution 2.8.1. thanks a lot!