GNOME Bugzilla – Bug 354507
All icon sizes should be installed
Last modified: 2007-05-16 12:08:15 UTC
Currently gnome-games only install scalable app icons for its games. That makes launchers on the desktop appear properly, but makes the icons look inferior when scaled down (in the panel for example). Applications should install an app icon into $prefix/share/icons/hicolor/$size/apps/. Daniel Derozier created a set that includes pixel-precise bitmaps at all the appropriate sizes (16x16, 22x22, 24x24, 32x32 and scalables) which I attach to this bugreport.
Created attachment 72269 [details] tar.bz2 archive of the gnome-games icons
Created attachment 72271 [details] Screenshot: Current situation - scaled icons lacking sharpnes, most of the detail getting lost.
Created attachment 72272 [details] Mockup: if all sizes are provided, the panel shows pixel-precise bitmaps
Jason, can you look at this ASAP?
The 48x48 pixmaps are included just like all the other gnome-games games in our module. If we want to add the pixel precise versions to the automake files, I suppose it's possilbe but I'll have to look at someone else's module to figure out the code for it.
Also, something appears to be wrong with the menus in general ... I didn't touch the Robots icons at all and they are fuzzy in your screenshot, so something else is going on.
The robots icon is blurry at even 48x48 as is in cvs. Anything at 48x48 is going to be blurry when it's scaled down that much, really. Davyd blogged about the bit he did for installing the various icons in gnome-applets. It seems like a good solution to use here, if you want to not create subdirectories for each size.
Well, I will go ahead an make this change. The icons that are there now are no different than any others we have had in their place in the past WRT sharpness. This will go in 2.16.1.
Fixing summary.
The 16x16 and 32x32 need to be installed as well (and 24x24, which is 22x22 with 1px transparent border?). Updating the summary for that. I also don't think we need to install a pre-rendered 48x48 png of the svg. Is there any particular reason this needs to be done?
Why 16, 32 and 24? Also note that only the 5 icons from David included in GNOME Games will have these versions. The other icons will not.
Well, the icons in the task list and window titles should look good as well, hence the 16. For 32, in at least SUSE versions of GNOME, the icons in the main menu are 32x32, and KDE also extensively uses the 32x32 size. There's also work being done to standardize the icon zoom sizes in nautilus to more sane sizes, in future versions, so 32x32 will be used, instead of having a 75% zoom which ends up at 36x36. Having the crisp 32x32 png will look much better than scaling the 48x48 svg down. And for 24x24, I believe it is actually the size currently being used by the panel menus. Only the 5 currently changed icons being updated is fine for 2.16. We can add the other icons for 2.18. Why weren't the others added, btw?
Sounds good. WRT to only 5, see my email to games-list.
Jason, do you have a patch for this bug before 2.16.1?
I haven't implemented it yet but I will try to get to it tomorrow (Friday) night. Hopefully it won't be too complicated and it'll be done by Saturday morning.
Implemented on HEAD and tested. Backporting now.
Back port completed. Tested. Works. Closing. BTW, no 24x24 version was provided so only 16, 22 and 32 were added.
Why aren't the 24x24 installed? They need to be installed as well.
Read comment #17. Do not re-open this bug.
Jason, isn't it possible to generate 24x24 icons from the original SVG?
In some cases. In others, the artist used different symbols for all icons less than size 32x32 - since we don't have the SVG for those versions, we can't generate the 24x24 icons. The artist should provide his version of the 24x24 icons.
Allow me to re-iterate. The 24x24 icons should be 22x22 with 1 pixel transparent border. Anyone can create these. They don't need to be provided by the artist. A simple "convert -border 1x1 -bordercolor Transparent in-22.png out-24.png" will do. Please do this and commit the 24x24 icons. I'm reopening this bug until this is done. This bug is not fixed until 24x24 versions are available also.
Leaving open. Fixing priority.
Created attachment 88133 [details] 24x24 sizes of all the icons Hope this will do!
Thanks Andreas, will add tonight.
The objection was from Alan and it's here: [1] http://mail.gnome.org/archives/games-list/2006-July/msg00001.html Jason compromised between the two opposing viewpoints and summarized the compromise here: [2] http://mail.gnome.org/archives/games-list/2006-August/msg00014.html As I see it, there have been a number of issues: 1. The Gnome games icons no longer match the style of the rest of the Gnome icons. 2. Gnome games is not distributing all the icon sizes which causes small icons (e.g. menus) to be blurry 3. Daniel Derozier created a set of new icons in the Tango style. Alan gave some feedback in [1] which highlighted some potential problems. 4. Daniel's set did not provide the 24x24 icons. What state we are in now: - We have a complete set of Gnome game icons in sizes 16x16, 24x24 (from Andreas Nilsson), 32x32, 48x48 and scalable - Some of these icons are included in Gnome Games 2.16, most are not - Some work has been completed getting all the new icons (see bug 438032 which is essentially a duplicate of this one) into Gnome games 2.20. What I propose doing: - Installing all of these new icons (in all sizes) for release in Gnome Games 2.19.3. Icons will be installed into one location allowing easier reviewing (bug 359499) - Encouring any issues with the new icons to be opened in new specific bug reports, e.g. "Tali icon would be more consistent with red dice", "Icons missing drop shadows".
Jason: I apologise if I've accidentally hijacked your issue :)
*** Bug 438032 has been marked as a duplicate of this bug. ***
Created attachment 88157 [details] [review] Patch to use new Tango icons Second attempt at a patch to enable use of the new icons installed in icons/ Please check if it works for you
There was some discussion in bug 438032 about making these changes, I've closed it as I wasn't aware of this bug at the time (and it's essentially the same thing). So I've got all the 16x16, 22x22, 24x24, 32x32, 48x48 and scalable icons committed to svn head. I fixed a few icons that were not the correct sizes. If no complaints about the patch I'll commit for 2.19.3
I've committed the changes. Please open new bugs on any issues with the new icons.
Created attachment 88280 [details] The new icons on a white background
Created attachment 88281 [details] The new icons on a black background
Created attachment 88285 [details] Script to generate icon montage The script I used to generate the icon montages. Run from icons/