After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 354184 - Enable built-in gdk-pixbuf loaders even if USE_GMODULE
Enable built-in gdk-pixbuf loaders even if USE_GMODULE
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Windows
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 135704 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-09-03 21:29 UTC by Tor Lillqvist
Modified: 2010-07-10 04:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Suggested patch (31.99 KB, patch)
2006-09-03 21:34 UTC, Tor Lillqvist 		none Details | Review
Slightly corrected patch (31.95 KB, patch)
2006-09-04 11:42 UTC, Tor Lillqvist 		none Details | Review

Description Tor Lillqvist 2006-09-03 21:29:04 UTC 
Currently built-in gdk-pixbuf loaders are possible only when dynamic module loading is disabled (or doesn't work, which isn't very likely though). The below patch makes it possible to have built-in gdk-pixbuf loaders always. This would be desireable at least on Win32 as one relatively common error scenario there is to screw up an installation by misplacing the gdk-pixbuf.loaders file.
Comment 1 Tor Lillqvist 2006-09-03 21:34:19 UTC 
Created attachment 72156 [details] [review]
Suggested patch

This patch seems to work for me.
Comment 2 Tor Lillqvist 2006-09-04 11:42:02 UTC 
Created attachment 72196 [details] [review]
Slightly corrected patch
Comment 3 Hans Breuer 2006-10-07 20:33:27 UTC 
There is an alternate implementation (not including the configure stuff) in bug #135704, maybe together we can do the "clean implementation" Owen was not opposed to there ;)
Comment 4 Tor Lillqvist 2006-10-07 20:41:46 UTC 
Well, I think my patch here is a "clean implementation", what else did you expect me to say ;) (My patch lacks any makefile.msc changes, though.) Including the configure.in and Makefile.am changes is important for people to be able to check it out and maybe use it also on Unix (and mingw).
Comment 5 Matthias Clasen 2006-10-08 05:11:52 UTC 
I think your patch is fine, feel free to commit it.
Comment 6 Tor Lillqvist 2006-10-11 12:36:12 UTC 
OK, committed to HEAD. I assume you don't want this in the stable branch?
Comment 7 Tor Lillqvist 2006-10-11 12:53:44 UTC 
Hans, you probably want to apply the makefile.msc changes from #135704 now.
Comment 8 Tor Lillqvist 2006-10-11 12:54:29 UTC 
*** Bug 135704 has been marked as a duplicate of this bug. ***
Comment 9 Matthias Clasen 2006-10-11 13:04:30 UTC 
Re comment 6: Yes, lets keep it head-only. Its pretty clearly a new feature...