After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353874 - View mode doesn't work as expected
View mode doesn't work as expected
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
CVS
Other All
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-01 17:15 UTC by Thomas Van Machelen
Modified: 2006-10-25 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixing both issues (2.44 KB, patch)
2006-09-01 17:17 UTC, Thomas Van Machelen
committed Details | Review

Description Thomas Van Machelen 2006-09-01 17:15:31 UTC
Please describe the problem:
With f-spot replacing gthumb in ubuntu; i thought it might be a good idea to give some attention to the view mode of f-spot.

When you launch f-spot with the --view switch, some things don't work like expected:
1. when you open a file or a directory (from file -> open) nothing happens
2. when you focus the photo view and press left/roght or up/down the icon view overview doesn't scroll along

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Thomas Van Machelen 2006-09-01 17:17:29 UTC
Created attachment 72034 [details] [review]
Fixing both issues

This patch resolves both comments i made myself.  If anyone discovers things he would like to see changed about the --view mode, just drop me a line
Comment 2 Stephane Delcroix 2006-09-04 09:42:09 UTC
I just tested your patch, and it works as expected.

You asked to report other things that does'nt work as expected in view mode, here are mines:

- when viewing images without a thumbnail cached (common for the --view mode), new thumbnails are generated but not displayed ! You can test it by removing (or renaming temporarily your .thumbnails)

- what's the purpose of the "Directory v" button on the top of the left pane ? I'd prefer to have it working as a GtkFileChooser or like it works in gqview
Comment 3 Bengt Thuree 2006-09-23 13:24:39 UTC
I also tested the patch, and the issues the author stated it fixed nicely.

I also have a problem with the Thumbnails. Quite often they are not there at all (just blanks)

The Directory name in the top of the left pane, is changed to Folder in the patch attached to bug #323400

Would it be possible to get f-spot --view to check and see if another instance of --view is running, and if so instruct the other --view instance to display the photo(s)? Like gedit does. When you open a document in gedit, it just adds a new tab to an already running gedit session.

I change the status to Need Work, for the 
* Thumbnails missing
* Folder/Directory function do not work
Comment 4 Larry Ewing 2006-10-20 07:02:55 UTC
the thumbnail issue should be fixed now. The button is supposed to work like evince but I never finished the code.  View mode needs lots of love.
Comment 5 Stephane Delcroix 2006-10-25 14:21:52 UTC
I committed the original patch in cvs.

Let's open new bugs for the other remaining issues (one bug per bug entry).