After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353857 - [feature request] Frame-by-frame seeking
[feature request] Frame-by-frame seeking
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: Normal enhancement
: 0.10.3
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-01 16:03 UTC by Edward Hervey
Modified: 2007-03-06 20:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for single frame advance/retreat (2.62 KB, patch)
2007-03-06 05:05 UTC, Brandon Lewis
committed Details | Review

Description Edward Hervey 2006-09-01 16:03:22 UTC
From wiki.pitivi.org

A frame by frame mode allowing users to flick through a source video /final project video on a frame by frame basis.   Primarily for editing concerns as the timeline is only ideal for second-by-second editing and in most cases, 3 or 4 pixels on the scale is representing 24+ frames, which make it impossible to edit out bits which do not fall on a whole second /the odd frame the scale will let you select.

I'm sure this feature was to be implemented, but i saw no buttons ^^

* bilboed : frame by frame is tricky. Framerate up/down scaling is only done when rendering or when going through effects that need common framerates. If you have a simple timeline with two sources, one having 25fps and the other 30fps, then frame-by-frame has to be every 1/25s during the first source, and every 1/30s during the second source. There still isn't a convenient way in GStreamer to be able to do seeking at the frame level, so it has to be done using time. Maybe an intermediate solution would be to seek forward/backward by 1/<project fps> seconds.
Comment 1 Brandon Lewis 2007-03-06 05:05:43 UTC
Created attachment 84034 [details] [review]
Patch for single frame advance/retreat

Followed recommendation of current +/- (1/project_fps). Implemented playground forward_one and back_one, as well as Viewer next_cb, back_cb.
Comment 2 Brandon Lewis 2007-03-06 06:15:25 UTC
doesn't work right if you drag a source directly into the viewer, but works fine for objects in the timeline. 
Comment 3 Edward Hervey 2007-03-06 20:10:37 UTC
Thanks a lot. I fixed some methods also in objectfactories to make the code a bit smaller.

2007-03-06  Edward Hervey  <edward@fluendo.com>

	Patch by: Brandon Lewis <brandon_lewis@berkeley.edu>

	* pitivi/playground.py:
	* pitivi/ui/viewer.py:
	Implement frame-by-frame forward/backward seeking in the playground
	and in the UI.
	Brandon, welcome to the PiTiVi developer team :)
	Fixes #353857