After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353828 - The play button is active when "No sound" is selected
The play button is active when "No sound" is selected
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sound
2.15.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 333890 385435 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-09-01 11:27 UTC by Vassilis Pandis
Modified: 2007-01-14 18:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Proposed patch (1.88 KB, patch)
2006-09-01 11:29 UTC, Vassilis Pandis
committed Details | Review

Description Vassilis Pandis 2006-09-01 11:27:51 UTC
Hello. This is a bug originally reported in the Ubuntu bugtracker by Sylvain Defresne ( http://launchpad.net/bugs/32861 ) :

When the "No sound" options is selected for an event, the play button is still active, but an error message is displayed when clicked. The button should be disabled when this option is selected, as no sound can be played.
Comment 1 Vassilis Pandis 2006-09-01 11:29:54 UTC
Created attachment 72016 [details] [review]
Proposed patch

This is a patch attached to the original bug report. Thanks to Sylvain Defresne for hacking this up ( I speculate that it was .diff-ed against the version of control-center that comes with gnome 2.24)
Comment 2 Christian Kirbach 2006-09-01 23:41:34 UTC
*** Bug 333890 has been marked as a duplicate of this bug. ***
Comment 3 Christian Kirbach 2006-09-01 23:49:59 UTC
confirming report. first glance at the patch ...

-	GtkWidget *play_button;
+	// GtkWidget *play_button;

this line should probably be simply removed.

patch works for me.
Comment 4 Baptiste Mille-Mathias 2006-12-13 13:19:39 UTC
*** Bug 385435 has been marked as a duplicate of this bug. ***
Comment 5 Thomas Wood 2007-01-14 18:58:08 UTC
I've committed a modified version of the patch. Basically I just fixed the indentation, and used gtk_button_new_with_stock() rather than inserting a stock image into the button manually.