After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353803 - GtkEntry unneccesarily resets im context at commit
GtkEntry unneccesarily resets im context at commit
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-09-01 09:59 UTC by Alexander Larsson
Modified: 2006-09-09 05:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test case (923 bytes, text/plain)
2006-09-01 09:59 UTC, Alexander Larsson
  Details
Fix for GtkEntry (1.66 KB, patch)
2006-09-01 10:00 UTC, Alexander Larsson
none Details | Review

Description Alexander Larsson 2006-09-01 09:59:25 UTC
This was initially discovered in eel:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203865

The issue is that on commit eel would reset the IM context, which would cause any leftover preedit state to be cleared. GtkEntry seems to have a similar problem. There was a fix for a similar issue after EelEditableEntry was created based on GtkEntry:

Mon Dec 16 21:39:28 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkentry.c (gtk_entry_enter_text): Call
	gtk_entry_set_position_internal() that takes a
	new "reset_IM" parameter, so that we avoid the
	problem where committing text would reset the
	input method. (#74381, Kang Jeong-Hee)

However, this only handles the case where setting the position would cause an IM reset. In the usecase happening with nautilus we also deleted the selection causing another reset.

I'm attaching a test case that can be used together with the scim-hangul and the testcase in the bug refered to above (" rhwhdqo") and a fix for GtkEntry.
Comment 1 Alexander Larsson 2006-09-01 09:59:52 UTC
Created attachment 72012 [details]
test case
Comment 2 Alexander Larsson 2006-09-01 10:00:41 UTC
Created attachment 72014 [details] [review]
Fix for GtkEntry
Comment 3 Matthias Clasen 2006-09-01 14:44:57 UTC
Fix needs to be backported to the stable branch after the next release.

2006-09-01  Matthias Clasen  <mclasen@redhat.com>
        * gtk/gtkentry.c: Don't unnecessarily reset the im context
        when deleting the selection.  (#353803, Alex Larsson)
Comment 4 Matthias Clasen 2006-09-09 05:14:49 UTC
committed to stable, too