After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353691 - History handlers should be disabled by default because of the CPU consumption
History handlers should be disabled by default because of the CPU consumption
Status: RESOLVED FIXED
Product: deskbar-applet
Classification: Deprecated
Component: general
Git master
Other All
: Normal minor
: ---
Assigned To: Deskbar Applet Maintainer(s)
Deskbar Applet Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-08-31 14:29 UTC by Thomas Karmann
Modified: 2006-10-18 10:56 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16



Description Thomas Karmann 2006-08-31 14:29:26 UTC
Please describe the problem:
From time to time (ca every 5 minutes) deskbar-applet takes 90% of the cpuload. During this period it does not react to useractions like clicking the applet or pressing the shortcut.

Steps to reproduce:



Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Nigel Tao 2006-08-31 23:56:37 UTC
Can you list what extensions you have enabled?  And if, by selectively disabling some of them, can you make the symptoms disappear?
Comment 2 Thomas Karmann 2006-09-01 15:33:17 UTC
Hi,
after a long time of testing (i disabled all plugins, and enabled them one after another), I think the "Web History" plugin ("Open your web history by name") is responsible for this ressource-attack.
Comment 3 Raphael Slinckx 2006-09-03 15:57:40 UTC
We can't really do otherwise as it is. We need the browser to export a service allowing to search his history, and not parsing the xml file ourselves..
Comment 4 Thomas Karmann 2006-09-03 16:15:58 UTC
Then, in my opinion, the plugin shoud be disabled per default. Deskbar is not in a usable state when it does not react to input from time to time...

Or am I the only one this problem occures? I'm using galeon as gnome default browser.
Comment 5 Raphael Slinckx 2006-09-03 16:27:14 UTC
You are right that it should be disabled per default. Marking as such for next release.
Comment 6 Nigel Tao 2006-09-04 05:49:18 UTC
Ah, Galeon.  If I recall correctly, Galeon isn't really updated these days (there was a proposal for Galeon to be implemented as plug-ins on top of Epiphany), and none of the core Deskbar devs uses Galeon with any regularity.  I think I wrote the original Galeon (XBEL??) parser really quickly without using Galeon itself for more than ten minutes (and hence on a really tiny history file).  If we disable anything in a maintenance release, I would disable Web History *for Galeon only*.

Ideally, someone would knuckle down with a real-world Galeon history file and bash Deskbar's parser into shape.  Or at least profile to see where all the CPU is burning.
Comment 7 Raphael Slinckx 2006-09-04 18:20:37 UTC
Nigel: This concerns all the history handlers, because they all do basically the same: the parse the (possibly huge) history xml file in memory. While you have generally less bookmarks to parse, so that's why i suggest we disable history reading..
Comment 8 Raphael Slinckx 2006-10-18 10:56:33 UTC
Disabled for default in schema in CVS