GNOME Bugzilla – Bug 353193
Ok/Cancel buttons should be Discard/Cancel
Last modified: 2006-10-27 16:16:45 UTC
I've got a report from a Debian user, who suggested to change the OK button with discard when discarding a record. Please read http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=383153. I've included the report below: ******* When pressing cancel after a recording (without first saving), there is a warning that you'll lose data. The buttons under it are Ok and Cancel. Since many people only read the buttons, this is not very useful. It would be better to have them named Discard and Cancel (Discard is a Gtk Stock button as well, I think). *******
I'm the Debian user, and I heard that a patch would be welcome. I'll attach it to this report. I thought there was a stock "discard" button, but appearantly there isn't, so I just used the text "Discard" without an icon. Also, I haven't been able to test it, since for some reason recording doesn't work at all for me anymore lately. I think that's a bug in gstreamer though. It compiles fine though, so I suppose it should be ok. The patch also changes the "Cancel" button in the normal dialog to close, because you need to use it after saving. If the dialog would automatically close after save, "Cancel" would be appropriate, but in this case it isn't IMO. But if you disagree, of course just don't change it. :-)
Created attachment 72306 [details] [review] patch to implement the buttons naming changes
Comment on attachment 72306 [details] [review] patch to implement the buttons naming changes Sorry about the junk, I forgot to save the cleaned version of the patch before sending it. Please ignore the "Only in" lines, and the configuration part.
Created attachment 72308 [details] [review] Cleaned patch Or better, here's the cleaned version of the patch. :-)
Mind if I commit this to CVS, zaheer?
Thanks, I've committed a slightly modified version of your patch. 2006-10-27 Wouter Bolsterlee <wbolster@cvs.gnome.org> * istanbul/main/save_window.py: Use better button labels. Fixes bug #353193. (I also fixed some tabs vs. spaces problems)