GNOME Bugzilla – Bug 353081
Process invocation needs to be wrapped in a try/catch to handle errors
Last modified: 2006-11-27 18:01:46 UTC
What were you doing when the application crashed? Enabling beagle live plugin -- starting beagle daemon. Distribution: Ubuntu 6.10 (edgy) Gnome Release: 2.15.92 2006-08-22 (Ubuntu) BugBuddy Version: 2.15.92 Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0 CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0 Traceback (most recent call last):
+ Trace 71064
self.more_button_callback(self.dialog)
gobject.spawn_async(["beagled"], flags=gobject.SPAWN_SEARCH_PATH)
Note that this is not a dupe of 352595. Mark - I take it that you don't have beagle installed?
Right I think we need to try/catch that gobject.spawn_async. Or is there a way to easiky check if beagled is installed (note that deskbar doesn't require the holmes UI to run).
Fix comitted in HEAD, thanks for the report
Three comments and a fix within a couple of days. Fantastic. Thanks guys for this and all your work on Deskbar. [Nigel- your comment was correct, I didn't have beagle installed]
*** Bug 356292 has been marked as a duplicate of this bug. ***
(In reply to comment #2) > Right I think we need to try/catch that gobject.spawn_async. Or is there a way > to easiky check if beagled is installed [...] (In reply to comment #3) > Fix comitted in HEAD, thanks for the report I take it that you now actually try/catch gobject.spawn_async, right? Probably the only generic fix. See bug 356292. :)
*** Bug 356795 has been marked as a duplicate of this bug. ***
*poke* comment 6, please ;)
Karsten, sorry for not following up... But here goes :-D It appears that we don't try/catch that spawn_async, I don't know what Raph was referring to in comment 3. However I have added a fix in the 2.16 branch (and head shortly), it now shows a warning dialog if it fails. There are some strings that need translation, I have not gettext'ed them, can we add strings in the stable branch? BTW: Karsten: Thanks a billion trillion times for your major bugzilla work! I don't know what I'd have done without you (I think I speak on behalf of the entire deskbar team).
"There are some strings that need translation, I have not gettext'ed them, can we add strings in the stable branch?" Only with permission from gnome-i18n@. However, adding strings and not gettexting them is the worst possible solution. This is a string freeze breakage and must be either avoided or approved by gnome-i18n@. For more details, see http://live.gnome.org/MaintainersCorner/StringFreeze Possible solutions are: 1, reverting the bug fix from 2.16 2, marking the strings for translation after approval
*** Bug 357291 has been marked as a duplicate of this bug. ***
*** Bug 357414 has been marked as a duplicate of this bug. ***
Gabor: I removed the dialog from the 2.16 branch. Now we just pipe an error msg to stderr. The "fix" is still there. One could defend that we should not catch the exception to give visible feedback that we failed to start beagled. However I decided that displaying a crash dialog was more intimidating than "informing" - so I kept the beagled startup in a try/catch.
*** Bug 357562 has been marked as a duplicate of this bug. ***
*** Bug 357607 has been marked as a duplicate of this bug. ***
(In reply to comment #9) > BTW: Karsten: Thanks a billion trillion times for your major bugzilla work! I > don't know what I'd have done without you (I think I speak on behalf of the > entire deskbar team). You're welcome, Mikkel. (and the entire deskbar team ;) Regarding this bug and the try/catch: You guys keep on mentioning beagled only. However, that's exactly what I was about. A bunch of the duplicates fail at starting different executables. So I hope you armored gobject.spawn_async() with a try/catch, and not a beagled specific solution, right? (Otherwise, we'd need to reopen this bug.)
*** Bug 362703 has been marked as a duplicate of this bug. ***
Fixed in CVS for armoring spawn. Needs also a gui in the future
*** Bug 366397 has been marked as a duplicate of this bug. ***
*** Bug 374691 has been marked as a duplicate of this bug. ***
*** Bug 376774 has been marked as a duplicate of this bug. ***
*** Bug 377414 has been marked as a duplicate of this bug. ***
*** Bug 378570 has been marked as a duplicate of this bug. ***
*** Bug 378930 has been marked as a duplicate of this bug. ***