After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352957 - replace term "accelerator" in External Tools Manager
replace term "accelerator" in External Tools Manager
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-26 08:46 UTC by Joachim Noreiko
Modified: 2019-03-23 20:46 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Patch of plugins/externaltools/tools/tools.glade (54.08 KB, patch)
2006-11-08 18:21 UTC, Joachim Noreiko 		none Details | Review
Updated version of the patch (27.33 KB, patch)
2006-11-21 18:04 UTC, Joachim Noreiko 		none Details | Review

Description Joachim Noreiko 2006-08-26 08:46:15 UTC 
+++ This bug was initially created as a clone of Bug #352244 +++

The Style Guide recommends against using the term 'accelerator'. 'shortcut key' should be used instead.

http://developer.gnome.org/documents/style-guide/gnome-glossary-generic-terms.html
Comment 1 Steve Frécinaux 2006-08-26 12:20:34 UTC 
Irony is that that term was used for convenience with snippets manager (at the beginning "shortcut" was used)

Unfortunately this can't be fixed before the end of string freeze...
Comment 2 Paolo Borelli 2006-11-07 20:54:27 UTC 
Joachim, do you feel like fixing this?
Comment 3 Joachim Noreiko 2006-11-07 21:02:01 UTC 
I'll have a go, but I can't compile to check everything works.
Comment 4 Joachim Noreiko 2006-11-08 18:21:05 UTC 
Created attachment 76223 [details] [review]
Patch of plugins/externaltools/tools/tools.glade

Glade 3 has changed *everything* about the tools.glade file it seems.
Comment 5 Steve Frécinaux 2006-11-20 09:09:48 UTC 
Since the last update of the External Tool plugin, this file is in the glade-3 format. Could you update your patch and commit it please ?
Comment 6 Joachim Noreiko 2006-11-21 18:04:00 UTC 
Created attachment 76985 [details] [review]
Updated version of the patch

Sorry Steve, it's really messing up.

I updated, got a very nasty conflict.
So I wiped my copy and did a fresh checkout of the file.

Opened it in Glade 3, changed the label, saved it. 
Did a diff...

It's not as massive as last time, but still quite alarming.
I'm attaching it anyway, as I'm utterly baffled and I don't want to break anything.
Comment 7 Steve Frécinaux 2006-11-29 23:21:30 UTC 
Apparently those changes are due to fixes in Glade-3, your version is probably newer than mine. What version of glade-3 did you use ?

I'm bored with those glade issues...
Comment 8 Joachim Noreiko 2006-12-01 17:08:35 UTC 
Glade 3.0.2
Comment 9 Paolo Borelli 2006-12-18 21:11:59 UTC 
I went on and simply committed the string change. We'll see later what to do with glade file format.