After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352838 - Crash when logging out remote kde session
Crash when logging out remote kde session
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.15.x
Other All
: Normal critical
: ---
Assigned To: GDM maintainers
GDM maintainers
: 357632 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-08-25 12:35 UTC by Guillaume Bedot
Modified: 2006-10-25 18:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
fix crash (595 bytes, patch)
2006-08-25 12:55 UTC, Frederic Crozat 		none Details | Review

Description Guillaume Bedot 2006-08-25 12:35:28 UTC 
Steps to reproduce:
1. open kde via gdm/xdmcp
2. close kde



Stack trace:
trace got with gdb :
(gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault.
gdm_handle_user_message (conn=0x80a2228, msg=0x80a70c0 "QUERY_LOGOUT_ACTION", data=0x0)
    at gdm.c:3189
3189                    sysmenu = gdm_get_value_bool_per_display (disp->name, GDM_KEY_SYSTEM_MENU);


Other information:
patch to fix this bug :
--- daemon/gdm.c.orig   2006-08-25 13:37:48.000000000 +0200
+++ daemon/gdm.c        2006-08-25 13:39:41.000000000 +0200
@@ -3186,7 +3186,6 @@
                gboolean sysmenu;
 
                disp = gdm_connection_get_display (conn);
-               sysmenu = gdm_get_value_bool_per_display (disp->name, GDM_KEY_SYSTEM_MENU);
 
                /* Only allow locally authenticated connections */
                if ( ! GDM_CONN_AUTHENTICATED (conn) ||
@@ -3198,6 +3197,8 @@
                        return;
                }
 
+                sysmenu = gdm_get_value_bool_per_display (disp->name, GDM_KEY_SYSTEM_MENU);
+
                msg = g_string_new ("OK");
 
                logout_action = disp->logout_action;
Comment 1 Frederic Crozat 2006-08-25 12:55:13 UTC 
Created attachment 71592 [details] [review]
fix crash

I'm attaching Guillaume patch for easier managment
Comment 2 Frederic Crozat 2006-08-25 12:55:50 UTC 
Confirming bug (this is when using Xgl/AIGLX FYI).
Comment 3 Guillaume Bedot 2006-08-25 13:34:52 UTC 
or simply plain X.org + XDCMP
Comment 4 Brian Cameron 2006-09-11 20:39:11 UTC 
Thanks for the bug report.  I notice that calling get_config on GDM_KEY_SYSTEM_MENU happens in 3 similar places and changed all 3 places

+ GDM_SUP_QUERY_LOGOUT_ACTION
+ GDM_SUP_SET_LOGOUT_ACTION
+ GDM_SUP_SET_SAFE_LOGOUT_ACTION

I updated the code so the call to get the GDM_KEY_SYSTEM_MENU happens
after the "authentication check" in all 3 cases.

Fixed in CVS head and 2.16 branch.
Comment 5 Brian Cameron 2006-10-25 18:12:57 UTC 
*** Bug 357632 has been marked as a duplicate of this bug. ***