After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352812 - Bug in gs-lock-plug.c (version 2.15.7 of gnome-screensaver)
Bug in gs-lock-plug.c (version 2.15.7 of gnome-screensaver)
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: dialog
2.15.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-25 09:12 UTC by Eric Lassauge
Modified: 2006-08-28 14:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
gnome-screensaver-2.15.7-lock-plug.patch (1.22 KB, patch)
2006-08-25 09:13 UTC, Eric Lassauge 		none Details | Review

Description Eric Lassauge 2006-08-25 09:12:55 UTC 
In gs-lock-plug.c the glade file for the dialog application is read and used:
if you change to so,ething else than the default (for example I switch to
the Fedora Core 5 provided fedoralogo-floaters-lock-dialog) and some Widgets
are not defined in the glade file it crashes the dialog (on Gtk_Hide_Widget for
the logout or swith_user buttons, even if they are not used).

The proposed patch will correct the behavior for some of the widgets (maybe there
are some others that are wrong ?).

With the included patch and a slightly corrected fedoralogo-floaters glade file
it now works perfectly.
Comment 1 Eric Lassauge 2006-08-25 09:13:38 UTC 
Created attachment 71573 [details] [review]
gnome-screensaver-2.15.7-lock-plug.patch
Comment 2 William Jon McCann 2006-08-25 14:43:51 UTC 
Nice catch.  Patch looks pretty good except for the indentation and the spurious gs_debug statement.  Also, for next time, patches are easier to read if you use the "cvs diff -pu".  Fixed in HEAD - thanks.
Comment 3 Eric Lassauge 2006-08-28 14:45:57 UTC 
The gs_debug was added on purpose so you can easily check which "dialog_theme" is currently selected in Gconf ... But it's as you want :->