After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352781 - rounded corners
rounded corners
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Drawing
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks:
 
 
Reported: 2006-08-25 03:19 UTC by Matthias Clasen
Modified: 2007-03-27 22:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (3.97 KB, patch)
2006-08-25 03:19 UTC, Matthias Clasen 		none Details | Review
second attempt, handle general polygons with rounded corners (10.65 KB, patch)
2006-08-27 22:56 UTC, Matthias Clasen 		none Details | Review
patch against libgnomekbd (10.22 KB, patch)
2007-03-18 01:37 UTC, Matthias Clasen 		none Details | Review

Description Matthias Clasen 2006-08-25 03:19:06 UTC 
The keyboard drawing code ignores the rounded corners that XKB geometry allows
to specify. I have a patch which implements this only for axis-aligned 
rectangles (not for rotated rectangles or general polygons), but that is
already enough to drastically improve the appearance of many layouts.

The patch probably depends on the patches in bug 352776, bug 352778
Comment 1 Matthias Clasen 2006-08-25 03:19:49 UTC 
Created attachment 71561 [details] [review]
patch
Comment 2 Matthias Clasen 2006-08-27 22:56:41 UTC 
Created attachment 71727 [details] [review]
second attempt, handle general polygons with rounded corners
Comment 3 Sergey V. Udaltsov 2006-08-29 22:59:55 UTC 
Matthias, this is really impressive, I must admit. I will play with it and see how it works. Anyway, it is too late for 2.16
Comment 4 Rodrigo Moya 2007-01-08 17:31:33 UTC 
Sergey, any news on this?
Comment 5 Rodrigo Moya 2007-01-08 17:33:31 UTC 
Ugh, dind't mean to close it
Comment 6 Matthias Clasen 2007-01-08 19:02:56 UTC 
The patch needs to be ported to libgnomekbd.
Comment 7 Sergey V. Udaltsov 2007-01-11 17:12:22 UTC 
Unfortunately currently I cannot test it - since Ubuntu broken the preview functionality (their xlib has XGetKeyboard broken)
Comment 8 Sergey V. Udaltsov 2007-03-17 00:44:17 UTC 
Is there a chance to get the patch ported to libgnomekbd?
Comment 9 Matthias Clasen 2007-03-18 01:37:33 UTC 
Created attachment 84810 [details] [review]
patch against libgnomekbd

Sorry, I had forgotten to attach the new patch here.
Comment 10 Sergey V. Udaltsov 2007-03-27 22:32:20 UTC 
Matthias, thanks for your patch. It had 2 minor problems:
1. Unused static function "draw" - I removed it
2. You did not scale the radius. I applied gdouble (new) version of xkb_to_pixmap function - so the image looks more realistic now.

Anyway, thanks a lot for your patch. The image is really more sexy now.