After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352777 - rotated text drawn badly
rotated text drawn badly
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Drawing
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Sergey V. Udaltsov
Control-Center Maintainers
Depends on:
Blocks: 352778
 
 
Reported: 2006-08-25 03:03 UTC by Matthias Clasen
Modified: 2007-03-17 01:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.59 KB, patch)
2006-08-25 03:04 UTC, Matthias Clasen
none Details | Review
patch ported to libgnomekbd (1.45 KB, patch)
2007-01-24 20:33 UTC, Matthias Clasen
none Details | Review
rotated text before the patch (25.54 KB, image/png)
2007-01-24 20:44 UTC, Matthias Clasen
  Details
rotated text after the patch (52.38 KB, image/png)
2007-01-24 20:45 UTC, Matthias Clasen
  Details

Description Matthias Clasen 2006-08-25 03:03:27 UTC
The keyboard layout widget does some manual manipulation with the pango layout
for rotated text which cause the text to come out badly, with some staircase
effect.
Comment 1 Matthias Clasen 2006-08-25 03:04:19 UTC
Created attachment 71558 [details] [review]
patch
Comment 2 Rodrigo Moya 2006-08-27 10:39:15 UTC
Sergey, does this look ok to you?
Comment 3 Sergey V. Udaltsov 2006-08-29 22:34:08 UTC
Well, IIRC Pango antialiazes the text - and I would like to keep the text rotated. Matthias, could you please provide some ugly screenshot?
Comment 4 Matthias Clasen 2007-01-24 20:33:34 UTC
Created attachment 81108 [details] [review]
patch ported to libgnomekbd

Here is the same patch, ported to libgnomekbd.
Comment 5 Matthias Clasen 2007-01-24 20:44:10 UTC
Created attachment 81110 [details]
rotated text before the patch
Comment 6 Matthias Clasen 2007-01-24 20:45:10 UTC
Created attachment 81111 [details]
rotated text after the patch
Comment 7 Sergey V. Udaltsov 2007-01-24 22:30:45 UTC
Ok, now it makes sense to me. The only problem is that I cannot verify it now - Ubuntu's X are broken in regard to XGetKeyboard. But once I get it back - I'll apply your patch, thanks.
Comment 8 Sergey V. Udaltsov 2007-03-17 01:16:00 UTC
It seems the text is correctly rotated now. I am closing this bug. If it is still not ok with you - feel free to reopen and blame me.