GNOME Bugzilla – Bug 352767
Calendar is displayed as plain text, if UUEncoded
Last modified: 2013-09-10 14:04:39 UTC
Calendar UI is not rendered if the *.ics attachment is in UUEncode (begin 666/stuff/end). Steps to replicate: 1) Obtain an email with a calendar attached as UUEncode. Microsoft Exchange Web generates such emails. I will try to attach one exported message to this bug report. 2) Open this email with Mozilla. Calendar will be displayed in plain-text (text contents of the *.ics file). Expected results: same behavior as for MIME attachments. Calendar UI has to be displayed. I will try to attach a patch that fixed this issue for me. It got ignored on the patches forum. Hopefully, it will find its way into one of the releases.
Created attachment 71556 [details] [review] proposed patch alas, it took me almost half a year to find time to register it as a bug report. It is a one line fix though. Hopefuly it will not be to hard to change the current code base in a similar way.
hey nick, thanks a lot for the patch! can you perhaps attach an UUEncode ics example file (please make sure that there is no confidential data included), so i can test this patch? thanks in advance!
Created attachment 71597 [details] sample message with such attachment attached is an email that can be used for testing. It took a while to clean all the private data from it. I was able to import it into Evolution using Import/Single File function.
Created attachment 71600 [details] I used a wrong file extension for the calendar file Evolution seems to ignore the extension but I attach this second fixed version just in case.
i took a look at the testmail before and after applying your patch, and it works fine for me. the appointment also sounds nice. ;-) we should get this in for evolution 2.8.1 (we're already under code freeze for 2.8.0).
I reckon someone from the mailer team to review this patch. Adding varadhan and sankar in the CC list.
assigning it to sankar.
Looks good. Commit with ChangeLog.
nick: thanks again for the patch! (for future reference, please add the bug id to your changelog entry. applied your changelog entry to /mail/changelog instead of /changelog :-) committed on behalf of nick to CVS HEAD (which is evolution 2.8.x and 2.9.x currently) and gnome-2-14 branch (which is evolution 2.6.x currently): http://cvs.gnome.org/viewcvs/evolution/mail/em-format-html.c?r1=1.92&r2=1.93 http://cvs.gnome.org/viewcvs/evolution/mail/em-format-html.c?r1=1.86&r2=1.86.2.1 fix will be included in evolution 2.8.1.