GNOME Bugzilla – Bug 352578
unchecking speech does not disable speech
Last modified: 2006-08-28 17:07:32 UTC
Please describe the problem: If I uncheck the use of speech in the orca config ui speech is still enabled Steps to reproduce: 1. Bring up the orca config ui 2. uncheck speech 3. press OK Actual results: Speech is still enabled Expected results: Speech should be disabled but braille or mag should still work if they are enabled Does this happen every time? yes Other information: This is with the latest orca from cvs as of 8/23
It looks like the GUI preferences dialog is forcing speech to always be True. Can you please try an experiment: 1) Set speech to False (i.e., uncheck the box) in the Orca preferences dialog and press OK to accept the settings. 2) Look for the orca.settings.enableSpeech line in ~/.orca/user-settings.py. Is it set to True or False?
Created attachment 71704 [details] [review] Patch to hopefully fix the problem. There is also a secondary potential change needed here. At the end of the _init() routine, there is also a line: self.prefsDict["enableSpeech"] = True before we initially show the Orca Preferences GUI state after the user has typed Insert-Space. In other words, just before that GUI is shown, we always enable speech. Do we want to leave this in?
I think the default value for enableSpeech should be True (as it is in settings.py), but once the user preferences override this, we should respect it. So, I think the secondary change you suggest is probably the right thing to do.
Created attachment 71735 [details] [review] Adjustment to the patch to include the potential second fix. Adjusted patch to hopefully take care of the second patch. Will, as I wasn't suggesting anything in my last comment (just telling what's currently there), I want to double check that this is what you want before I check it in. Note that if there is no user defined setting for "enableSpeech" in ~/.orca/user-settings.py, it defaults to the value in settings.py (which is True), so I think taking that line out should work nicely.
Assuming you've tested it thoroughly, especially making sure that speech still works when it is supposed to and doesn't when it's not, then this looks good to me. I'm also assuming you've tried various tests where you've set the enable speech checkox to a given state, quit orca, restart it and make sure it's what was expected. Same goes for hiding and showing the GUI dialog. If all checks out, go ahead and commit. Thanks!
Well there is something weird going on here. I can turn speech off and quit Orca, then when I restart it it'll come up with no speech. I can then do a Control-Space to bring up the Orca preferences and nothing will be initially spoken and the "enable speech" checkbox is not ticked, but if I arrow right three times to get to the Magnifier pane, by the time I get there, speech has magically started again. Still investigating...
In short, speech is starting up again once the Orca Preferences GUI is shown because none of the Orca speech routines check the current setting of settings.enableSpeech. I plan to check in the second version of the patch attached to this bug which will fix the original stated problem, then open another bug for the speech persistence problem once Orca has reshown the Preferences GUI.
Patch checked into CVS HEAD. I've opened bug #353269 for the "speech restarting" problem.