GNOME Bugzilla – Bug 352476
[wavpack] documentation, unit tests, memleak fix
Last modified: 2006-08-23 10:32:44 UTC
Hi, the attached patches add 3 unit test suites for all 3 wavpack elements, documentation for them and a fix for a memleak that showed up while creating the unit tests. Bye
Created attachment 71421 [details] [review] wavpack-docs.diff
Created attachment 71422 [details] [review] wavpack-tests.diff
Created attachment 71423 [details] [review] /wavpackenc-memleak.diff
Created attachment 71424 [details] [review] wavpack-docs.diff
Created attachment 71425 [details] [review] wavpack-tests.diff
Created attachment 71426 [details] [review] wavpack-docs.diff
Created attachment 71427 [details] [review] wavpackenc-memleak.diff
Thanks, docs and tests committed: 2006-08-23 Tim-Philipp Müller <tim at centricular dot net> Patch by: Sebastian Dröge <slomo at circular-chaos.org> * tests/check/Makefile.am: * tests/check/elements/.cvsignore: * tests/check/elements/wavpackdec.c: (setup_wavpackdec), (cleanup_wavpackdec), (GST_START_TEST), (wavpackdec_suite), (main): * tests/check/elements/wavpackenc.c: (setup_wavpackenc), (cleanup_wavpackenc), (GST_START_TEST), (wavpackenc_suite), (main): * tests/check/elements/wavpackparse.c: (wavpackparse_found_pad), (setup_wavpackparse), (cleanup_wavpackparse), (GST_START_TEST), (wavpackparse_suite), (main): Add unit tests for wavpack elements (#352476). 2006-08-23 Tim-Philipp Müller <tim at centricular dot net> Patch by: Sebastian Dröge <slomo at circular-chaos.org> * docs/plugins/Makefile.am: * docs/plugins/gst-plugins-bad-plugins-docs.sgml: * docs/plugins/gst-plugins-bad-plugins-sections.txt: * docs/plugins/gst-plugins-bad-plugins.hierarchy: * docs/plugins/inspect/plugin-wavpack.xml: * ext/wavpack/gstwavpackdec.c: * ext/wavpack/gstwavpackdec.h: * ext/wavpack/gstwavpackenc.c: * ext/wavpack/gstwavpackenc.h: * ext/wavpack/gstwavpackparse.c: * ext/wavpack/gstwavpackparse.h: Add docs for wavpack elements (#352476). About that memleak fix ... the code is wrong of course, but I'm not sure the fix is right. We need to send a newsegment event on both pads before sending any data, so the event bit needs to be done in both cases. 2006-08-23 Tim-Philipp Müller <tim at centricular dot net> * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_push_block): Fix mem leak, send newsegment event on correction pad as well (#352476). * ext/wavpack/gstwavpackparse.c: (gst_wavpack_parse_base_init): Restore original author (on Sebastian's request). * tests/check/Makefile.am: * tests/check/gst-plugins-bad.supp: Add (so far empty) suppression file for -bad. Remove wavpackenc test from VALGRIND_TO_FIX now that the leak is fixed.