After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352444 - Crashed while away from desk
Crashed while away from desk
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: gail
1.12.x
Other All
: High critical
: ---
Assigned To: Li Yuan
Li Yuan
: 356449 356564 361056 362070 362682 363995 364087 365759 366349 366374 367087 367491 367528 368107 369425 370088 371030 371922 372990 374883 375286 375717 376792 377489 377894 377913 378550 378703 379318 380695 380716 380760 380965 381094 381560 382080 382490 382511 383571 384308 385248 388061 388389 389344 389944 389980 391242 391693 391872 394335 395750 395800 396217 396616 396625 397274 398156 398394 400232 400415 400452 400466 400619 401244 401280 403054 404767 405222 405465 406136 406266 407599 408180 408701 408840 408842 411667 411881 412325 413227 413605 413653 413678 413859 414084 414462 415631 415996 417374 418980 420123 420189 423864 424285 424798 425729 428511 429130 430256 430324 431269 432248 432857 433214 434082 435488 435922 437251 437657 438625 438793 440360 441984 442875 444249 445665 449689 451907 453006 461257 466136 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-08-22 19:25 UTC by Stuart Langridge
Modified: 2007-09-04 15:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
gnome-panel-bugreport (7.54 KB, text/plain)
2006-11-05 19:38 UTC, MaXx Fomkin
  Details
patch for review (492 bytes, patch)
2006-12-13 10:37 UTC, Li Yuan
none Details | Review
new patch (960 bytes, patch)
2006-12-14 06:40 UTC, Li Yuan
committed Details | Review
valgrind log from gnome-terminal when it crashed (409.41 KB, text/plain)
2006-12-16 09:47 UTC, Kjartan Maraas
  Details
gnome-session valgrind log (378.98 KB, text/plain)
2006-12-16 09:49 UTC, Kjartan Maraas
  Details
patch to avoid double free (1.86 KB, patch)
2006-12-16 12:41 UTC, Li Yuan
committed Details | Review

Description Stuart Langridge 2006-08-22 19:25:17 UTC
Steps to reproduce:
1. No idea; it did it while I wasn't looking
2. 
3. 


Stack trace:
Debugging Information:

Backtrace was generated from '/usr/libexec/gnome-netstatus'

(no debugging symbols found)
Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
[Thread debugging using libthread_db enabled]
[New Thread -1223985472 (LWP 18126)]
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
0xffffe410 in __kernel_vsyscall ()

Thread 1 (Thread -1223985472 (LWP 18126))

  • #0 __kernel_vsyscall
  • #1 __waitpid_nocancel
    from /lib/tls/i686/cmov/libpthread.so.0
  • #2 libgnomeui_module_info_get
    from /usr/lib/libgnomeui-2.so.0
  • #3 <signal handler called>
  • #4 __kernel_vsyscall
  • #5 raise
    from /lib/tls/i686/cmov/libc.so.6
  • #6 abort
    from /lib/tls/i686/cmov/libc.so.6
  • #7 g_logv
    from /usr/lib/libglib-2.0.so.0
  • #8 g_log
    from /usr/lib/libglib-2.0.so.0
  • #9 g_assert_warning
    from /usr/lib/libglib-2.0.so.0
  • #10 ORBit_RootObject_duplicate_T
    from /usr/lib/libORBit-2.so.0
  • #11 CORBA_free
    from /usr/lib/libORBit-2.so.0
  • #12 CORBA_free
    from /usr/lib/libORBit-2.so.0
  • #13 ORBit_free_T
    from /usr/lib/libORBit-2.so.0
  • #14 ORBit_free
    from /usr/lib/libORBit-2.so.0
  • #15 CORBA_free
    from /usr/lib/libORBit-2.so.0
  • #16 gnome_accessibility_module_shutdown
    from /usr/lib/gtk-2.0/modules/libatk-bridge.so
  • #17 g_signal_stop_emission
    from /usr/lib/libgobject-2.0.so.0
  • #18 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #19 g_signal_emit_by_name
    from /usr/lib/libgobject-2.0.so.0
  • #20 gail_label_new
    from /usr/lib/gtk-2.0/modules/libgail.so
  • #21 gail_label_new
    from /usr/lib/gtk-2.0/modules/libgail.so
  • #22 gail_widget_new
    from /usr/lib/gtk-2.0/modules/libgail.so
  • #23 g_cclosure_marshal_VOID__PARAM
    from /usr/lib/libgobject-2.0.so.0
  • #24 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #25 g_signal_stop_emission
    from /usr/lib/libgobject-2.0.so.0
  • #26 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #27 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #28 g_object_interface_list_properties
    from /usr/lib/libgobject-2.0.so.0
  • #29 g_value_get_flags
    from /usr/lib/libgobject-2.0.so.0
  • #30 g_object_thaw_notify
    from /usr/lib/libgobject-2.0.so.0
  • #31 gtk_label_set_text
    from /usr/lib/libgtk-x11-2.0.so.0
  • #32 ??
  • #33 ??
  • #34 ??
  • #35 ??
  • #36 ??
  • #37 ??
  • #38 ??
  • #39 ??
  • #40 ??
  • #41 ??
  • #42 ??
  • #43 ??
  • #0 __kernel_vsyscall




Other information:
Ubuntu 6.06 dapper
Comment 1 Karsten Bräckelmann 2006-10-10 11:29:25 UTC
*** Bug 361056 has been marked as a duplicate of this bug. ***
Comment 2 Karsten Bräckelmann 2006-10-10 11:32:38 UTC
Moving to ATK.
Comment 3 Elijah Newren 2006-10-14 02:49:29 UTC
*** Bug 362070 has been marked as a duplicate of this bug. ***
Comment 4 Karsten Bräckelmann 2006-10-16 20:25:41 UTC
*** Bug 362682 has been marked as a duplicate of this bug. ***
Comment 5 bill.haneman 2006-10-16 21:30:31 UTC
Not sure these dups are valid! 

Note that the stack trace is bogus, no syms, so the api calls in the frames are invalid.

"Thanks for the bug report. Unfortunately, that stack trace is not very useful in determining the cause of the crash. Can you get us one with debugging symbols? Please see http://live.gnome.org/GettingTraces for more information on how to do so."
Comment 6 bill.haneman 2006-10-16 21:32:43 UTC
Also, probably not ATK/atk!  Certainly cannot tell from the stack trace...

_possibly_ at-spi.  or maybe gail...
Comment 7 Karsten Bräckelmann 2006-10-21 19:10:45 UTC
*** Bug 363995 has been marked as a duplicate of this bug. ***
Comment 8 André Klapper 2006-10-22 10:46:48 UTC
*** Bug 364087 has been marked as a duplicate of this bug. ***
Comment 9 bill.haneman 2006-10-22 17:00:56 UTC
Should we keep filing these bugs as dups while this bug is still NEEDINFO waiting for a good stack trace? Maybe one of these reporters would be able to help us get a better trace.  (the ones attached to this bug, and the dups I've seen, have been bogus due to lack of symbols in key libs, so we end up with the wrong function names in the backtrace...)
Comment 10 Karsten Bräckelmann 2006-10-27 16:37:33 UTC
*** Bug 365759 has been marked as a duplicate of this bug. ***
Comment 11 Rob Bradford 2006-10-28 16:13:46 UTC
*** Bug 366349 has been marked as a duplicate of this bug. ***
Comment 12 manumuller 2006-10-28 16:23:02 UTC
At the opening of evolution.
Comment 13 André Klapper 2006-10-29 23:31:46 UTC
*** Bug 367087 has been marked as a duplicate of this bug. ***
Comment 14 Karsten Bräckelmann 2006-10-30 12:11:39 UTC
*** Bug 367491 has been marked as a duplicate of this bug. ***
Comment 15 Karsten Bräckelmann 2006-10-30 12:11:46 UTC
*** Bug 367528 has been marked as a duplicate of this bug. ***
Comment 16 manumuller 2006-10-30 13:39:04 UTC
It Make me think about gajim how make this bug with sond or graphic alert (the only active programe I can see)
Comment 17 André Klapper 2006-10-31 16:17:31 UTC
*** Bug 368107 has been marked as a duplicate of this bug. ***
Comment 18 Behdad Esfahbod 2006-11-02 14:21:18 UTC
*** Bug 369425 has been marked as a duplicate of this bug. ***
Comment 19 André Klapper 2006-11-05 14:05:46 UTC
*** Bug 371030 has been marked as a duplicate of this bug. ***
Comment 20 André Klapper 2006-11-05 14:05:53 UTC
*** Bug 370088 has been marked as a duplicate of this bug. ***
Comment 21 MaXx Fomkin 2006-11-05 19:38:19 UTC
Created attachment 76046 [details]
gnome-panel-bugreport
Comment 22 MaXx Fomkin 2006-11-05 19:41:01 UTC
It crashed again.
Do I need to install any packages except gnome-panel-dbg?
Comment 23 bill.haneman 2006-11-06 15:14:29 UTC
Hi MaXx: looks like you need at-spi-dbg and gail-dbg, the stack trace still doesn't tell us what we need.  Thanks for posting it though!
Comment 24 Karsten Bräckelmann 2006-11-07 17:12:37 UTC
*** Bug 371922 has been marked as a duplicate of this bug. ***
Comment 25 André Klapper 2006-11-07 18:57:23 UTC
pasting the stacktrace provided by manumuller (thanks, CC'ing you here) at bug 352265 comment 122 and reopening this bug report here.
this trace still misses atk symbols, but at least provides the critical error warning.
bill, feel free to needinfo again. :-)


gnome-netstatus-rapport-d-anomalies.txt:
Memory status: size: 177176576 vsize: 0 resident: 177176576 share: 0 rss:
45187072 rss_rlim: 0
CPU usage: start_time: 1162582625 rtime: 0 utime: 59940 stime: 0 cutime:54383
cstime: 0 timeout: 5557 it_real_value: 0 frequency: 0

Backtrace was generated from '/usr/libexec/gnome-netstatus'

(no debugging symbols found)
Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
[Thread debugging using libthread_db enabled]
[New Thread -1225554256 (LWP 6050)]
0xffffe410 in __kernel_vsyscall ()

Thread 1 (Thread -1225554256 (LWP 6050))

  • #0 __kernel_vsyscall
  • #1 __waitpid_nocancel
    from /lib/tls/i686/cmov/libpthread.so.0
  • #2 gnome_gtk_module_info_get
    from /usr/lib/libgnomeui-2.so.0
  • #3 <signal handler called>
  • #4 __kernel_vsyscall
  • #5 raise
    from /lib/tls/i686/cmov/libc.so.6
  • #6 abort
    from /lib/tls/i686/cmov/libc.so.6
  • #7 IA__g_logv
  • #8 IA__g_log
  • #9 IA__g_assert_warning
    at gmessages.c line 552
  • #10 ORBit_RootObject_duplicate_T
    from /usr/lib/libORBit-2.so.0
  • #11 CORBA_free
    from /usr/lib/libORBit-2.so.0
  • #12 CORBA_free
    from /usr/lib/libORBit-2.so.0
  • #13 ORBit_free_T
    from /usr/lib/libORBit-2.so.0
  • #14 ORBit_free
    from /usr/lib/libORBit-2.so.0
  • #15 CORBA_free
    from /usr/lib/libORBit-2.so.0
  • #16 gnome_accessibility_module_shutdown
    from /usr/lib/gtk-2.0/modules/libatk-bridge.so
  • #17 gnome_accessibility_module_shutdown
    from /usr/lib/gtk-2.0/modules/libatk-bridge.so
  • #18 signal_emit_unlocked_R
    at gsignal.c line 2406
  • #19 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #20 IA__g_signal_emit
    at gsignal.c line 2243
  • #21 atk_object_notify_state_change
    from /usr/lib/libatk-1.0.so.0
  • #22 gail_widget_new
    from /usr/lib/gtk-2.0/modules/libgail.so
  • #23 IA__g_cclosure_marshal_VOID__BOOLEAN
    at gmarshal.c line 111
  • #24 IA__g_closure_invoke
    at gclosure.c line 490
  • #25 signal_emit_unlocked_R
    at gsignal.c line 2440
  • #26 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #27 IA__g_signal_emit_by_name
    at gsignal.c line 2267
  • #28 gail_widget_new
    from /usr/lib/gtk-2.0/modules/libgail.so
  • #29 gail_widget_new
    from /usr/lib/gtk-2.0/modules/libgail.so
  • #30 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 84
  • #31 IA__g_closure_invoke
    at gclosure.c line 490
  • #32 signal_emit_unlocked_R
    at gsignal.c line 2510
  • #33 IA__g_signal_emit_valist
    at gsignal.c line 2209
  • #34 IA__g_signal_emit
    at gsignal.c line 2243
  • #35 gtk_widget_event_internal
    at gtkwidget.c line 3911
  • #36 do_focus_change
    at gtkwindow.c line 4783
  • #37 _gtk_window_set_is_active
    at gtkwindow.c line 7757
  • #38 gtk_window_focus_in_event
    at gtkwindow.c line 4805
  • #39 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 84
  • #40 g_type_class_meta_marshal
    at gclosure.c line 567
  • #41 IA__g_closure_invoke
    at gclosure.c line 490
  • #42 signal_emit_unlocked_R
    at gsignal.c line 2478
  • #43 IA__g_signal_emit_valist
    at gsignal.c line 2209
  • #44 IA__g_signal_emit
    at gsignal.c line 2243
  • #45 gtk_widget_event_internal
    at gtkwidget.c line 3911
  • #46 IA__gtk_main_do_event
    at gtkmain.c line 1423
  • #47 gdk_event_dispatch
    at gdkevents-x11.c line 2320
  • #48 IA__g_main_context_dispatch
    at gmain.c line 2045
  • #49 g_main_context_iterate
    at gmain.c line 2677
  • #50 IA__g_main_loop_run
    at gmain.c line 2881
  • #51 bonobo_main
    from /usr/lib/libbonobo-2.so.0
  • #52 bonobo_generic_factory_main_timeout
    from /usr/lib/libbonobo-2.so.0
  • #53 bonobo_generic_factory_main
    from /usr/lib/libbonobo-2.so.0
  • #54 panel_applet_factory_main_closure
    from /usr/lib/libpanel-applet-2.so.0
  • #55 panel_applet_factory_main
    from /usr/lib/libpanel-applet-2.so.0
  • #56 ??
  • #57 _IO_stdin_used
  • #58 ??
  • #59 ??
  • #60 ??
#0  0
Comment 26 bill.haneman 2006-11-07 19:16:51 UTC
You had my hopes up for a minute there... :-)

But no :-(

The assert failure is bogus, it happens well past the point where the stack frames no longer make sense, as far as I can tell.

Andre, you say:
>this trace still misses atk symbols, but at least provides the critical error
>warning.

Do you mean the ORBit2 warning: 
  • #9 IA__g_assert_warning
    at gmessages.c line 552
  • #10 ORBit_RootObject_duplicate_T
    from /usr/lib/libORBit-2.so.0

I don't trust those stack frames - in any case the gail/atk ones are missing.  I'm afraid I will have to NEEDINFO it again...
Comment 27 Carlos Garcia Campos 2006-11-10 12:08:39 UTC
*** Bug 373360 has been marked as a duplicate of this bug. ***
Comment 28 Fabio Bonelli 2006-11-14 15:52:57 UTC
*** Bug 374883 has been marked as a duplicate of this bug. ***
Comment 29 Christian Kirbach 2006-11-14 21:13:32 UTC
*** Bug 375286 has been marked as a duplicate of this bug. ***
Comment 30 André Klapper 2006-11-16 01:48:51 UTC
*** Bug 375717 has been marked as a duplicate of this bug. ***
Comment 31 André Klapper 2006-11-18 23:42:12 UTC
*** Bug 376792 has been marked as a duplicate of this bug. ***
Comment 32 Susana 2006-11-20 22:03:20 UTC
*** Bug 377489 has been marked as a duplicate of this bug. ***
Comment 33 Susana 2006-11-21 23:33:13 UTC
*** Bug 377894 has been marked as a duplicate of this bug. ***
Comment 34 Susana 2006-11-21 23:33:26 UTC
*** Bug 377913 has been marked as a duplicate of this bug. ***
Comment 35 Mariano Suárez-Alvarez 2006-11-26 00:58:34 UTC
*** Bug 379318 has been marked as a duplicate of this bug. ***
Comment 36 Li Yuan 2006-11-27 07:35:58 UTC
add GNOME-a11y-bugs-EXT@sun.com to cc list
Comment 37 Li Yuan 2006-11-27 07:36:09 UTC
add GNOME-a11y-bugs-EXT@sun.com to cc list
Comment 38 André Klapper 2006-11-27 15:57:19 UTC
*** Bug 378550 has been marked as a duplicate of this bug. ***
Comment 39 André Klapper 2006-11-27 15:57:25 UTC
*** Bug 378703 has been marked as a duplicate of this bug. ***
Comment 40 Susana 2006-11-29 23:48:20 UTC
*** Bug 380695 has been marked as a duplicate of this bug. ***
Comment 41 Mariano Suárez-Alvarez 2006-11-30 18:05:45 UTC
*** Bug 380965 has been marked as a duplicate of this bug. ***
Comment 42 Mariano Suárez-Alvarez 2006-11-30 18:31:09 UTC
*** Bug 380716 has been marked as a duplicate of this bug. ***
Comment 43 bill.haneman 2006-11-30 18:48:40 UTC
Still looking for a useful stack trace for this bug...
Comment 44 André Klapper 2006-12-01 15:40:57 UTC
*** Bug 381094 has been marked as a duplicate of this bug. ***
Comment 45 André Klapper 2006-12-01 15:41:04 UTC
*** Bug 380760 has been marked as a duplicate of this bug. ***
Comment 46 André Klapper 2006-12-02 19:04:07 UTC
*** Bug 381560 has been marked as a duplicate of this bug. ***
Comment 47 Susana 2006-12-05 13:41:04 UTC
*** Bug 382511 has been marked as a duplicate of this bug. ***
Comment 48 Christian Kirbach 2006-12-05 19:54:47 UTC
Thanks for the bug report. Unfortunately, no stack trace is  very useful
in determining the cause of the crash. Can you get us one with debugging
symbols? Please see http://live.gnome.org/GettingTraces for more information on
how to do so.

plesae install the glib, ORBit and atk packages and attach the trace to this report. thanks.
Comment 49 André Klapper 2006-12-05 23:49:59 UTC
*** Bug 382490 has been marked as a duplicate of this bug. ***
Comment 50 Li Yuan 2006-12-06 08:10:32 UTC
Went through all the duplicates. Not find any useful trace. Most of them crashed in gnome-terminal, gnome-system-monitor when user open, maximize the window or login from screen saver.
I'm keeping gnome-terminal and gnome-system-monitor running with accessibility enabled, hoping can reproduce this.
Comment 51 Li Yuan 2006-12-07 07:07:12 UTC
I think "gnome_accessibility_module_shutdown"s in the trace should be spi_atk_emit_eventv and spi_atk_bridge_state_event_listener.
Comment 52 Bruno Boaventura 2006-12-08 02:43:10 UTC
*** Bug 383571 has been marked as a duplicate of this bug. ***
Comment 53 Benoît Dejean 2006-12-10 14:42:31 UTC
*** Bug 384308 has been marked as a duplicate of this bug. ***
Comment 54 Li Yuan 2006-12-11 09:35:23 UTC
Which kind of machine are you using? 32bit or 64bit?
Comment 55 Li Yuan 2006-12-13 09:09:16 UTC
I think the really crash point is spi_atk_emit_eventv (bridge.c:765).
spi_atk_emit_eventv calls CORBA_free, and finally in orbit-object.c: do_unref, the g_assert (robj->refs < ORBIT_REFCOUNT_MAX && robj->refs > 0) causes crash.

I think the reason is robj->refs is too large, currently ORBIT_REFCOUNT_MAX is 1<<20, maybe our refs exceed the number. That's why people get crash when system has run a long time.

This maybe because we do not free every Accessibility_EventDetails created in spi_init_any_* .
Comment 56 Li Yuan 2006-12-13 10:37:25 UTC
Created attachment 78273 [details] [review]
patch for review
Comment 57 Benoît Dejean 2006-12-13 11:34:48 UTC
*** Bug 385248 has been marked as a duplicate of this bug. ***
Comment 58 bill.haneman 2006-12-13 16:15:32 UTC
Great detective work Li!

Your fix looks reasonable - did you test that the ref count on some object was increasing greatly, just to confirm your suspicion?  
Comment 59 Li Yuan 2006-12-14 06:40:40 UTC
Created attachment 78342 [details] [review]
new patch
Comment 60 Li Yuan 2006-12-14 06:41:34 UTC
Yes, the ref is keeping increasing, up to 400 in 5 mins when I running gnome-system-log. But I found the root cause is not at CORBA_any's ref_counts, because that object is ORBIT_REFCOUNT_STATIC (Accessibility-common.c:2044). The ref_counts will not increase when create.

I found the real point is we do not unref some objects we create with spi_accessible_new. (in spi_atk_bridge_property_event_listener and spi_atk_bridge_signal_listener). So when we call bonobo_object_unref in spi_atk_emit_eventv, application crashes because the ref is too large.

I made a new patch and had a little test. The ref counts keeps under 10 now.
Comment 61 bill.haneman 2006-12-14 09:30:33 UTC
That's great news Li, thanks again.  I think you should commit the patch and mark as fixed - it's great that we can get this into the 2.17.4 release Monday!

Comment 62 bill.haneman 2006-12-14 09:32:29 UTC
Comment on attachment 78342 [details] [review]
new patch

Li: It would be great if you or someone could test this with valgrind (only available on linux I'm afraid) to make sure we're unreffing at the right places, i.e. test for double-frees.
Comment 63 Li Yuan 2006-12-14 11:35:17 UTC
I just ran valgrind for a while, looks fine.
Committed. 
BTW: I am applying for the upload permission, and I will ask Glenn or Brain to upload the new tarballs this time.

Have a good holiday:)
Comment 64 Kjartan Maraas 2006-12-16 00:03:40 UTC
I ran valgrind too and found this:

==4724== Invalid read of size 4
==4724==    at 0x497205B: ORBit_marshal_value (corba-any.c:152)
==4724==    by 0x4971FA5: ORBit_marshal_value (corba-any.c:166)
==4724==    by 0x49724A8: ORBit_marshal_any (corba-any.c:374)
==4724==    by 0x49721E0: ORBit_marshal_value (corba-any.c:139)
==4724==    by 0x4971FA5: ORBit_marshal_value (corba-any.c:166)
==4724==    by 0x4968767: orbit_small_marshal (orbit-small.c:353)
==4724==    by 0x4969BD9: ORBit_small_invoke_stub (orbit-small.c:646)
==4724==    by 0x4969E1D: ORBit_small_invoke_stub_n (orbit-small.c:575)
==4724==    by 0x4976721: ORBit_c_stub_invoke (poa.c:2643)
==4724==    by 0x5173463: Accessibility_EventListener_notifyEvent (Accessibility-stubs.c:321)
==4724==    by 0x51AC980: spi_atk_emit_eventv (bridge.c:740)
==4724==    by 0x51ACC92: spi_atk_bridge_exit_func (bridge.c:1263)
==4724==    by 0x4B80868: exit (exit.c:75)
==4724==    by 0x4B6AE63: (below main) (libc-start.c:253)
==4724==  Address 0x5748CF4 is 12 bytes inside a block of size 36 free'd
==4724==    at 0x4021FDA: free (vg_replace_malloc.c:233)
==4724==    by 0x4AEC2C0: g_free (gmem.c:187)
==4724==    by 0x496DAB4: ORBit_free_T (allocators.c:204)
==4724==    by 0x496DB30: ORBit_free (allocators.c:218)
==4724==    by 0x496DB9C: CORBA_free (allocators.c:143)
==4724==    by 0x51AC9E7: spi_atk_emit_eventv (bridge.c:762)
==4724==    by 0x51ACC47: spi_atk_bridge_exit_func (bridge.c:1257)

Is this related to this patch in any way?
Comment 65 Li Yuan 2006-12-16 07:40:19 UTC
Oh, I think so... Thank you very much.

I don't realize spi_atk_bridge_exit_func calls spi_atk_emit_eventv twice. 
Do you find any unexpected thing happened? A crash? The applications exit normally on my machine.

It is very strange that this function should be called when application exit, but I still can't find this problem with valgrind... :(
Which application did you run with valgrind?
Comment 66 Kjartan Maraas 2006-12-16 09:23:43 UTC
gnome-terminal crashed on me when logging out. I ran the entire gnome-session under valgrind when this happened.
Comment 67 Kjartan Maraas 2006-12-16 09:47:56 UTC
Created attachment 78463 [details]
valgrind log from gnome-terminal when it crashed
Comment 68 Kjartan Maraas 2006-12-16 09:49:08 UTC
Created attachment 78464 [details]
gnome-session valgrind log

gnome-session was the only other process that showed invalid reads from this session
Comment 69 Li Yuan 2006-12-16 12:40:25 UTC
Thank you Kjartan. I made a patch maybe can fix this problem. Can you help me to have a little test? I don't have build environment by my hand.
Thank you again.
Comment 70 Li Yuan 2006-12-16 12:41:14 UTC
Created attachment 78469 [details] [review]
patch to avoid double free
Comment 71 Kjartan Maraas 2006-12-17 13:18:15 UTC
Still seeing some invalid reads with this patch:

==4376== Invalid read of size 1
==4376==    at 0x4006238: strlen (mc_replace_strmem.c:246)
==4376==    by 0x495C6CD: CORBA_string_dup (corba-string.c:20)
==4376==    by 0x4EC508B: spi_init_any_object (util.c:153)
==4376==    by 0x4E8B133: spi_atk_bridge_init_object (bridge.c:1310)
==4376==    by 0x4E8B4F2: spi_atk_bridge_signal_listener (bridge.c:1113)
==4376==    by 0x4A3EE4D: signal_emit_unlocked_R (gsignal.c:2406)
==4376==    by 0x4A40596: g_signal_emit_valist (gsignal.c:2199)
==4376==    by 0x4A4333D: g_signal_emit_by_name (gsignal.c:2267)
==4376==    by 0x4E5A45A: gail_toplevel_show_event_watcher (gailtoplevel.c:278)
==4376==    by 0x4A3EE4D: signal_emit_unlocked_R (gsignal.c:2406)
==4376==    by 0x4A40596: g_signal_emit_valist (gsignal.c:2199)
==4376==    by 0x4A40758: g_signal_emit (gsignal.c:2243)
==4376==    by 0x4522247: gtk_widget_show (gtkwidget.c:2222)
==4376==    by 0x452B90E: gtk_window_present_with_time (gtkwindow.c:6248)
==4376==    by 0x452B978: gtk_window_present (gtkwindow.c:6200)
==4376==    by 0x805CBB3: terminal_app_new_terminal (terminal.c:2005)
==4376==    by 0x805D76B: new_terminal_with_options (terminal.c:1433)
==4376==    by 0x805E3C4: main (terminal.c:1761)
==4376==  Address 0x4B01250 is 240 bytes inside a block of size 296 free'd
==4376==    at 0x40054BB: realloc (vg_replace_malloc.c:306)
==4376==    by 0x4998A85: FcCharSetPutLeaf (fccharset.c:142)
==4376==    by 0x4998DA0: FcCharSetFindLeafCreate (fccharset.c:204)
==4376==    by 0x4998DE4: FcCharSetAddLeaf (fccharset.c:343)
==4376==    by 0x49998E6: FcCharSetOperate (fccharset.c:387)
==4376==    by 0x49A18C5: FcFontSetSort (fcmatch.c:607)
==4376==    by 0x49A1AB7: FcFontSort (fcmatch.c:836)
==4376==    by 0x425635A: _vte_fc_patterns_from_pango_font_desc (vtefc.c:449)
==4376==    by 0x4263E66: _vte_xft_set_text_font (vtexft.c:100)
==4376==    by 0x42554C5: _vte_draw_set_text_font (vtedraw.c:216)
==4376==    by 0x4247786: vte_terminal_set_font_full (vte.c:6268)
==4376==    by 0x4247B7B: vte_terminal_set_font (vte.c:6297)
==4376==    by 0x806CEAC: terminal_widget_set_pango_font (terminal-widget-vte.c:631)
==4376==    by 0x8068F11: terminal_screen_set_font (terminal-screen.c:835)
==4376==    by 0x8069230: terminal_screen_change_font (terminal-screen.c:939)
==4376==    by 0x80694FF: terminal_screen_reread_profile (terminal-screen.c:576)
==4376==    by 0x805CCA8: terminal_app_new_terminal (terminal.c:1971)
==4376==    by 0x805D76B: new_terminal_with_options (terminal.c:1433)
==4376==    by 0x805E3C4: main (terminal.c:1761)
Comment 72 Li Yuan 2006-12-17 15:14:04 UTC
I think this is another problem. Does the former invalid read disappear?
Comment 73 Kjartan Maraas 2006-12-17 15:23:19 UTC
Yes, the former one is gone now. I don't think it crashed either, but with all the invalid reads in the log I guess that's just by pure luck.
Comment 74 Kjartan Maraas 2006-12-17 19:17:16 UTC
Do you want me to file a new bug with the other invalid read?
Comment 75 Li Yuan 2006-12-18 02:06:55 UTC
Yes, please. Thank you.
Comment 76 Li Yuan 2006-12-18 05:30:25 UTC
Hi Kjartan, about the former gnome-terminal crash, did it happen only when you log out? (with gnome-terminal opening) Or it crash every time when you close gnome-terminal?
Comment 77 Kjartan Maraas 2006-12-18 11:52:37 UTC
I didn't test that I'm sad to say. I could back out the latest patch and try again if you want.
Comment 78 Li Yuan 2006-12-19 02:15:11 UTC
Maybe I don't understand you correctly. You said "gnome-terminal crashed on me when logging out.". Does that means gnome terminal crashed when you log out, and you don't know if it will crash when you using it?
Comment 79 Kjartan Maraas 2006-12-19 10:05:54 UTC
Yeah, I can retest without any patches to see if that clears things up.
Comment 80 Mariano Suárez-Alvarez 2006-12-20 21:43:28 UTC
*** Bug 388061 has been marked as a duplicate of this bug. ***
Comment 81 Mariano Suárez-Alvarez 2006-12-27 07:13:00 UTC
*** Bug 389944 has been marked as a duplicate of this bug. ***
Comment 82 Susana 2006-12-27 12:57:32 UTC
*** Bug 388389 has been marked as a duplicate of this bug. ***
Comment 83 Susana 2006-12-27 12:58:14 UTC
*** Bug 389344 has been marked as a duplicate of this bug. ***
Comment 84 Susana 2006-12-27 12:58:44 UTC
*** Bug 389980 has been marked as a duplicate of this bug. ***
Comment 85 Susana 2006-12-31 11:44:02 UTC
*** Bug 391242 has been marked as a duplicate of this bug. ***
Comment 86 palfrey 2007-01-02 19:01:54 UTC
*** Bug 391872 has been marked as a duplicate of this bug. ***
Comment 87 palfrey 2007-01-02 19:02:03 UTC
*** Bug 391693 has been marked as a duplicate of this bug. ***
Comment 88 Li Yuan 2007-01-08 05:36:17 UTC
*** Bug 356449 has been marked as a duplicate of this bug. ***
Comment 89 palfrey 2007-01-12 01:21:50 UTC
*** Bug 394335 has been marked as a duplicate of this bug. ***
Comment 90 Bruno Boaventura 2007-01-13 03:09:45 UTC
*** Bug 395750 has been marked as a duplicate of this bug. ***
Comment 91 Jens Granseuer 2007-01-13 13:18:47 UTC
*** Bug 395800 has been marked as a duplicate of this bug. ***
Comment 92 palfrey 2007-01-17 00:33:57 UTC
*** Bug 396217 has been marked as a duplicate of this bug. ***
Comment 93 palfrey 2007-01-17 00:34:04 UTC
*** Bug 396616 has been marked as a duplicate of this bug. ***
Comment 94 palfrey 2007-01-17 00:34:11 UTC
*** Bug 396625 has been marked as a duplicate of this bug. ***
Comment 95 palfrey 2007-01-17 00:34:17 UTC
*** Bug 397274 has been marked as a duplicate of this bug. ***
Comment 96 Christian Kirbach 2007-01-18 22:15:19 UTC
*** Bug 398156 has been marked as a duplicate of this bug. ***
Comment 97 palfrey 2007-01-19 16:04:43 UTC
*** Bug 398394 has been marked as a duplicate of this bug. ***
Comment 98 palfrey 2007-01-24 18:42:33 UTC
*** Bug 400232 has been marked as a duplicate of this bug. ***
Comment 99 Bruno Boaventura 2007-01-25 22:07:29 UTC
*** Bug 400452 has been marked as a duplicate of this bug. ***
Comment 100 Bruno Boaventura 2007-01-25 22:08:28 UTC
*** Bug 400466 has been marked as a duplicate of this bug. ***
Comment 101 Bruno Boaventura 2007-01-25 22:14:48 UTC
*** Bug 400619 has been marked as a duplicate of this bug. ***
Comment 102 Bruno Boaventura 2007-01-27 05:06:32 UTC
*** Bug 401244 has been marked as a duplicate of this bug. ***
Comment 103 palfrey 2007-01-27 15:38:27 UTC
*** Bug 401280 has been marked as a duplicate of this bug. ***
Comment 104 André Klapper 2007-01-27 23:58:32 UTC
*** Bug 400415 has been marked as a duplicate of this bug. ***
Comment 105 palfrey 2007-02-01 13:15:35 UTC
*** Bug 403054 has been marked as a duplicate of this bug. ***
Comment 106 Li Yuan 2007-02-05 08:10:36 UTC
*** Bug 356564 has been marked as a duplicate of this bug. ***
Comment 107 Li Yuan 2007-02-05 08:24:37 UTC
*** Bug 372990 has been marked as a duplicate of this bug. ***
Comment 108 André Klapper 2007-02-06 00:00:29 UTC
*** Bug 404767 has been marked as a duplicate of this bug. ***
Comment 109 Mariano Suárez-Alvarez 2007-02-07 09:26:34 UTC
*** Bug 405222 has been marked as a duplicate of this bug. ***
Comment 110 André Klapper 2007-02-07 21:50:22 UTC
*** Bug 405465 has been marked as a duplicate of this bug. ***
Comment 111 Bruno Boaventura 2007-02-09 16:46:37 UTC
*** Bug 406136 has been marked as a duplicate of this bug. ***
Comment 112 Christian Kirbach 2007-02-10 00:55:30 UTC
*** Bug 406266 has been marked as a duplicate of this bug. ***
Comment 113 Susana 2007-02-14 12:12:49 UTC
*** Bug 407599 has been marked as a duplicate of this bug. ***
Comment 114 Mariano Suárez-Alvarez 2007-02-15 17:57:20 UTC
*** Bug 408180 has been marked as a duplicate of this bug. ***
Comment 115 Susana 2007-02-17 13:43:47 UTC
*** Bug 408840 has been marked as a duplicate of this bug. ***
Comment 116 André Klapper 2007-02-18 13:56:40 UTC
*** Bug 408701 has been marked as a duplicate of this bug. ***
Comment 117 André Klapper 2007-02-18 13:56:54 UTC
*** Bug 408842 has been marked as a duplicate of this bug. ***
Comment 118 Vincent Untz 2007-02-21 20:52:33 UTC
*** Bug 366374 has been marked as a duplicate of this bug. ***
Comment 119 Bruno Boaventura 2007-02-25 14:43:11 UTC
*** Bug 411881 has been marked as a duplicate of this bug. ***
Comment 120 Bruno Boaventura 2007-02-25 14:44:53 UTC
*** Bug 411667 has been marked as a duplicate of this bug. ***
Comment 121 Harry Lu 2007-02-26 09:38:48 UTC
*** Bug 382080 has been marked as a duplicate of this bug. ***
Comment 122 Pedro Villavicencio 2007-02-28 22:46:50 UTC
*** Bug 413227 has been marked as a duplicate of this bug. ***
Comment 123 Susana 2007-03-02 15:31:17 UTC
*** Bug 413678 has been marked as a duplicate of this bug. ***
Comment 124 Mariano Suárez-Alvarez 2007-03-02 17:14:12 UTC
*** Bug 413859 has been marked as a duplicate of this bug. ***
Comment 125 Pedro Villavicencio 2007-03-07 12:45:01 UTC
*** Bug 415631 has been marked as a duplicate of this bug. ***
Comment 126 Susana 2007-03-10 18:16:47 UTC
*** Bug 414084 has been marked as a duplicate of this bug. ***
Comment 127 Susana 2007-03-10 18:19:59 UTC
*** Bug 414462 has been marked as a duplicate of this bug. ***
Comment 128 Susana 2007-03-13 01:03:41 UTC
*** Bug 417374 has been marked as a duplicate of this bug. ***
Comment 129 André Klapper 2007-03-17 20:22:12 UTC
*** Bug 418980 has been marked as a duplicate of this bug. ***
Comment 130 André Klapper 2007-03-17 20:22:19 UTC
*** Bug 413653 has been marked as a duplicate of this bug. ***
Comment 131 André Klapper 2007-03-17 20:22:25 UTC
*** Bug 413605 has been marked as a duplicate of this bug. ***
Comment 132 André Klapper 2007-03-17 20:22:32 UTC
*** Bug 412325 has been marked as a duplicate of this bug. ***
Comment 133 Bruno Boaventura 2007-03-19 21:29:34 UTC
*** Bug 420123 has been marked as a duplicate of this bug. ***
Comment 134 Bruno Boaventura 2007-03-19 21:29:43 UTC
*** Bug 420189 has been marked as a duplicate of this bug. ***
Comment 135 André Klapper 2007-03-31 14:10:55 UTC
*** Bug 415996 has been marked as a duplicate of this bug. ***
Comment 136 André Klapper 2007-03-31 14:11:09 UTC
*** Bug 423864 has been marked as a duplicate of this bug. ***
Comment 137 André Klapper 2007-03-31 14:11:21 UTC
*** Bug 424285 has been marked as a duplicate of this bug. ***
Comment 138 André Klapper 2007-03-31 14:11:36 UTC
*** Bug 424798 has been marked as a duplicate of this bug. ***
Comment 139 palfrey 2007-04-16 14:33:06 UTC
*** Bug 430256 has been marked as a duplicate of this bug. ***
Comment 140 palfrey 2007-04-16 15:13:09 UTC
*** Bug 430324 has been marked as a duplicate of this bug. ***
Comment 141 Pascal Terjan 2007-04-16 19:17:11 UTC
*** Bug 425729 has been marked as a duplicate of this bug. ***
Comment 142 Pascal Terjan 2007-04-16 19:17:20 UTC
*** Bug 428511 has been marked as a duplicate of this bug. ***
Comment 143 Pedro Villavicencio 2007-04-22 21:48:38 UTC
*** Bug 432248 has been marked as a duplicate of this bug. ***
Comment 144 Diego Escalante Urrelo (not reading bugmail) 2007-04-24 23:44:19 UTC
*** Bug 432857 has been marked as a duplicate of this bug. ***
Comment 145 palfrey 2007-04-26 17:35:43 UTC
*** Bug 429130 has been marked as a duplicate of this bug. ***
Comment 146 palfrey 2007-04-26 17:43:27 UTC
*** Bug 431269 has been marked as a duplicate of this bug. ***
Comment 147 palfrey 2007-04-26 17:47:17 UTC
*** Bug 433214 has been marked as a duplicate of this bug. ***
Comment 148 palfrey 2007-04-28 18:23:53 UTC
*** Bug 434082 has been marked as a duplicate of this bug. ***
Comment 149 palfrey 2007-05-03 18:08:41 UTC
*** Bug 435488 has been marked as a duplicate of this bug. ***
Comment 150 Christian Kirbach 2007-05-04 18:48:00 UTC
*** Bug 435922 has been marked as a duplicate of this bug. ***
Comment 151 Reinout van Schouwen 2007-05-10 08:01:48 UTC
*** Bug 437251 has been marked as a duplicate of this bug. ***
Comment 152 palfrey 2007-05-11 14:43:12 UTC
*** Bug 437657 has been marked as a duplicate of this bug. ***
Comment 153 Bruno Boaventura 2007-05-15 21:22:43 UTC
*** Bug 438625 has been marked as a duplicate of this bug. ***
Comment 154 Pedro Villavicencio 2007-05-23 02:49:45 UTC
*** Bug 440360 has been marked as a duplicate of this bug. ***
Comment 155 palfrey 2007-06-01 13:23:44 UTC
*** Bug 442875 has been marked as a duplicate of this bug. ***
Comment 156 Behdad Esfahbod 2007-06-14 21:43:30 UTC
*** Bug 444249 has been marked as a duplicate of this bug. ***
Comment 157 André Klapper 2007-06-20 21:49:33 UTC
*** Bug 445665 has been marked as a duplicate of this bug. ***
Comment 158 André Klapper 2007-06-20 21:49:39 UTC
*** Bug 441984 has been marked as a duplicate of this bug. ***
Comment 159 André Klapper 2007-06-20 21:49:43 UTC
*** Bug 438793 has been marked as a duplicate of this bug. ***
Comment 160 palfrey 2007-06-29 11:57:07 UTC
*** Bug 451907 has been marked as a duplicate of this bug. ***
Comment 161 Christian Kirbach 2007-07-02 20:34:22 UTC
*** Bug 453006 has been marked as a duplicate of this bug. ***
Comment 162 Teppo Turtiainen 2007-07-16 18:15:06 UTC
*** Bug 449689 has been marked as a duplicate of this bug. ***
Comment 163 Rob Bradford 2007-07-29 13:04:08 UTC
*** Bug 461257 has been marked as a duplicate of this bug. ***
Comment 164 André Klapper 2007-09-04 15:52:23 UTC
*** Bug 466136 has been marked as a duplicate of this bug. ***