After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352434 - Spin buttons aren't rendered inside of entry like XP theme on MS-Windows
Spin buttons aren't rendered inside of entry like XP theme on MS-Windows
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.8.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-08-22 18:34 UTC by Brad Taylor
Modified: 2016-01-24 06:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
XP's UpDownButton (4.62 KB, image/bmp)
2006-08-22 18:35 UTC, Brad Taylor
Details
Gtk Spin button rendered using MS-Windows theme (25.78 KB, image/bmp)
2006-08-22 18:36 UTC, Brad Taylor
Details
Experiment with different border color. (1.20 KB, image/png)
2006-10-01 21:17 UTC, Oskar Berggren
Details

Description Brad Taylor 2006-08-22 18:34:37 UTC
If you look at the attached screenshots, you'll notice that the SpinButton's buttons aren't rendered inside of the entry, but instead outside of it, making it look strange due to the few pixels of white drawn by XP.  Also, the SpinButton's buttons aren't as wide as the default XP ones.
Comment 1 Brad Taylor 2006-08-22 18:35:15 UTC
Created attachment 71390 [details]
XP's UpDownButton
Comment 2 Brad Taylor 2006-08-22 18:36:11 UTC
Created attachment 71391 [details]
Gtk Spin button rendered using MS-Windows theme
Comment 3 Oskar Berggren 2006-10-01 21:15:44 UTC
A GtkSpinButton is a GtkEntry rendered at a slightly smaller width than the entire
spinbutton widget. The arrows are then draw at the left. It would seem difficult
to make it look like XP because of this (but I'm guessing wildly here), at least
not without intrusive changes to the widget itself.

How difficult would it be to just enlarge the arrows and, more importantly,
replace the white border with the same color as is around the entry box? Changing
the border color makes it look much more "together" and nicer IMO. I will attach 
an example of this.

This is a quite important bug I believe, cause right now it does look rather weird.
Comment 4 Oskar Berggren 2006-10-01 21:17:55 UTC
Created attachment 73776 [details]
Experiment with different border color.
Comment 5 Dominic Lachowicz 2006-10-01 21:26:45 UTC
Oskar, could you attach your border color patch?
Comment 6 Oskar Berggren 2006-10-02 20:05:29 UTC
That was actually just a few minutes with Paint to test the idea - there is no patch yet. If there is interest in having it look this way, I'm willing to have a go at implementing it.

My time is severly limited at the moment and I'm new to the gtk code so it will take me a while. If anyone else feels like doing it, go ahead. Please note it here though before I spend too much time on it.
Comment 7 Matthias Clasen 2016-01-24 06:03:12 UTC
patch didn't happen