After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352088 - Typo in Gtk::Button::get_image_position
Typo in Gtk::Button::get_image_position
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: general
2.10.x
Other All
: Normal minor
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2006-08-19 23:22 UTC by Kevin Daughtridge
Modified: 2006-08-23 11:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Kevin Daughtridge 2006-08-19 23:22:02 UTC 
When the *_image_position functions were added to Gtk::Button, the _WRAP_METHOD for get_image_position was entered as "set_image_position". The actual set_image_position is itself correct. Present in HEAD at line 99 of gtk/src/button.hg.
Comment 1 Jonathon Jongsma 2006-08-20 01:37:44 UTC 
Indeed, you are correct.  Right now we have this:

  _WRAP_METHOD(void set_image_position(PositionType position), gtk_button_set_image_position)
  _WRAP_METHOD(PositionType set_image_position() const, gtk_button_get_image_position)

I'm not completely sure about the API stability rules.  Murray, can we fix something that's obviously incorrectly named, or do we have to live with this for now?  I can commit if you give me the go-ahead.
Comment 2 Murray Cumming 2006-08-21 10:36:52 UTC 
I think this is more or less OK to fix. Ask for release-team permission please first though.
Comment 3 Jonathon Jongsma 2006-08-21 13:26:02 UTC 
email sent to release-team, waiting for response.
Comment 4 Jonathon Jongsma 2006-08-21 19:14:36 UTC 
Fix committed.  I've sent an email to release-team asking for somebody to roll a new release.
Comment 5 Murray Cumming 2006-08-23 08:36:17 UTC 
I assume that the release team has approved the API change then.

A new release is fine, but it will be easier for them if you do it for them and tell them where to find the tarball.
Comment 6 Jonathon Jongsma 2006-08-23 11:53:52 UTC 
Yes, I rolled the release and sent it off the Elijah and he put it up on the GNOME servers.