GNOME Bugzilla – Bug 352084
Fullscreen menu item changes when selected
Last modified: 2012-11-14 01:28:25 UTC
The Fullscreen menu item is changed into Leave Fullscreen when selected. The HIG (implicitely) suggests that Fullscreen be made a CheckMenuItem, though, and notes: "Never change the label of a check box menu item in response to the user selecting the item." On the same line: the HIG says: "When your application is running in full screen mode, hide the menubar by default. [...] A Leave Fullscreen button should be placed in the upper right hand corner of the window. etc" (See <http://developer.gnome.org/projects/gup/hig/2.0/menus.html>; wouldn't it be nice if the HIG as posted had anchors to each point being made, for easy linking into it?)
Here comes a patch which does most of what the HIG wants, except for making the button disappear after 5 seconds of not moving the mouse or (more appropriately, since this app is one where the mouse is frequently used...) making it slide out of the window.
Created attachment 71223 [details] [review] Make the Fullscreen menu item follow the HIG This additionally adds a bit of magic to keep -W -Wall happy.
Hello Mariano, Let me first start by saying that usability is important to gnome-games, and that you come with some good suggestions here. However, since gnome-games is in UI and string freeze now, this change will have to wait until the 2.17.x development cycle, which begins when GNOME 2.16 has been released. Further, we will need to discuss the proper implementation of the fullscreen mode. Your patch only changes same-gnome only, but the fullscreen menu item needs to be consistent in all the games. If this menu item behaves differently in different same-gnome, it will confuse users. This makes your patch uncommittable as it is now.
The label changing is mildly confusing for users but the more important underlying issue and the reason for that guidline is accessibility. Screen readers have no way of knowing another label will appear later requiring them to go back and read it again.
This is not NOTABUG. In any case, this should be changed into a global bug covering all games that offer fullscreening. "We will need to discuss the proper implementation [...]" in no way means the issue went away. Reopening.
Re-assigning to new default owner.
The games no-longer share this code. Please open against each game if still applicable.