After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352007 - last entered text remains in entry
last entered text remains in entry
Status: RESOLVED FIXED
Product: deskbar-applet
Classification: Deprecated
Component: general
2.15.x
Other Linux
: Normal normal
: ---
Assigned To: Deskbar Applet Maintainer(s)
Deskbar Applet Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-08-19 05:50 UTC by Danielle Madeley
Modified: 2006-09-02 20:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Adds GConf key to enable/disable this feature (2.64 KB, patch)
2006-08-20 14:33 UTC, Sebastian Pölsterl
none Details | Review
Improved patch (4.98 KB, patch)
2006-08-23 15:07 UTC, Sebastian Pölsterl
none Details | Review

Description Danielle Madeley 2006-08-19 05:50:18 UTC
This is specifically in Entriac mode, the last searched for text remains in the entry, allowing someone who is shoulder surfing to find out what the last action I carried out was. Deskbar 2.14 used to clear the text.

Clearing the text is backwards to the way the quicksearch bar in Firefox works (for example), so perhaps not a useful default, perhaps this could be a (hidden) option.
Comment 1 Sebastian Pölsterl 2006-08-20 14:33:04 UTC
Created attachment 71248 [details] [review]
Adds GConf key to enable/disable this feature

This patch works with currently all UIs. Nevertheless, it might not work with custom UIs because it makes use of the cuemiac attribute.
Comment 2 Raphael Slinckx 2006-08-21 13:15:53 UTC
Sebastian: I see a proble with the patch, indeed the value stored in GCONF is never read from gconf, and also it should react to changes in that key in gconf and update the boolean so it zorks for next query.
Besides, could you make it  non cueiac specific, for exaple by adding a new function to DeskbarUI like clear_text ?
Thanks !
Comment 3 Sebastian Pölsterl 2006-08-23 15:07:49 UTC
Created attachment 71467 [details] [review]
Improved patch

This patch adds the features requested by Raphael
Comment 4 Raphael Slinckx 2006-08-23 15:25:32 UTC
Thanks for the patch, commited in HEAD !
Comment 5 Sebastian Pölsterl 2006-08-27 11:23:53 UTC
A minor bug appeared:

There's an attribute called self.clear_entry and a method
Therefore, one of them must be renamed.
Comment 6 Mikkel Kamstrup Erlandsen 2006-09-02 20:20:47 UTC
Sebastian: I opened bug #354014 about this. It has a patch, but we have to break freeze, or wait for 2.16.1...