GNOME Bugzilla – Bug 351957
Orca should allow the setting of the source and target displays for magnification
Last modified: 2008-07-22 19:24:24 UTC
Orca currently only supports split screen magnification. For users with multihead displays or other such capabilities, Orca should allow the user to specify the source and target displays.
Created attachment 71170 [details] [review] Partial fix - allows user to specify magnifierSourceDisplay and magnifierTargetDisplay in settings This patch allows a user to specify the target and source displays for magnification in their ~/.orca/user-settings.py or ~/.orca/orca-customizations.py file. For example: orca.settings.magnifierSourceDisplay=":0.0" orca.settings.magnifierTargetDisplay=":0.1" This is only half of the fix, but it will work for the motivated user that's able to edit a text file. The other half of the fix is to allow these to be set via the configuration GUI so the user doesn't have to edit ~/.orca/user-settings.py by hand.
The magnification preferences panel should have two text areas to set the properties listed in comment #1: Source Display: _________ Target Display: _________ I'm not sure what the right "default" values should be. I'd guess that nothing means the property should not be set, allowing this to work OK across logins on something like a SunRay. If the value is set, it should be a valid X Window System DISPLAY string (e.g., ":0" or ":0.0" or "my.machine.domain:0.1").
Created attachment 73062 [details] [review] Patch to add these two settings into the Orca GUI Preferences magnifier pane. Hooked this up to two new text areas in the magnifier pane in the Orca Preferences GUI. Adjusted the existing magnierSourceDisplay and magnifierTargetDisplay usage in mag.py to be magSourceDisplay and magTargetDisplay to retain a consistent naming scheme with the existing magnifier preferences.
I've checked these changes into CVS HEAD. I'm not closing as FIXED yet, because I don't know how to test it. It would also be nice if it was possible to detect whether the user had supplied an invalid source or target display and speak an error message in that case. In other words, needs a little more work.
Comment from Will: "Xnest -ac :1" seems to work for me on Ubuntu. I did the testing of using the GUI to set the source and target display. It works." Thanks Will. Closing as FIXED. (PS: It doesn't seem that there is a way to check to see if we have an invalid source or target display, so I'm unable to do anything there. Not a biggie).