After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351823 - shorcut A for Aspect Ratio not displayed in the menu
shorcut A for Aspect Ratio not displayed in the menu
Status: RESOLVED WONTFIX
Product: totem
Classification: Core
Component: Movie player
1.5.x
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
ghop[2007-20]
Depends on: 370034
Blocks:
 
 
Reported: 2006-08-17 20:20 UTC by Baptiste Mille-Mathias
Modified: 2014-01-26 00:14 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Attempt at a patch to fix this per above comment (2.39 KB, patch)
2007-12-17 22:49 UTC, Patrick Hulin 		rejected Details | Review

Description Baptiste Mille-Mathias 2006-08-17 20:20:38 UTC 
The letter A is not displayed in the entry "Aspect Ratio" in the menu to inform the user he can switch the ratio with this shortcut.
Comment 1 Bastien Nocera 2006-08-17 22:00:40 UTC 
How would we show it?
A submenu can't have hotkeys.
Comment 2 Baptiste Mille-Mathias 2006-08-17 22:05:53 UTC 
(In reply to comment #1)
> How would we show it?
> A submenu can't have hotkeys.
> 

Does it means hotkey can't be displayed in menu, or can't be assigned? because actually, if you press "A", the aspect ratio changes.

(I trying to update the totem doc, sorry for dumb question)
Comment 3 Bastien Nocera 2006-08-17 22:11:10 UTC 
That it can't be displayed. It is however documented in the README (or should be if it isn't).
Comment 4 Baptiste Mille-Mathias 2006-08-17 22:25:46 UTC 
hotkey A is not defined in the README.

should I file a bug against gtk to provide availability to display hotkey on submenu or this not needed?
Comment 5 Bastien Nocera 2006-08-17 22:34:21 UTC 
No, 'A' cycles through the aspect ratios, and it wouldn't be useful for other apps. Best would be to move the 'A' hotkey around the menu when activated, and make sure it's correctly documented (README and online docs)
Comment 6 Bastien Nocera 2006-11-03 14:41:15 UTC 
There doesn't seem to be any easy way to change the accelerator of a GtkAction. Filed bug 370034 against gtk+ for that.
Comment 7 Patrick Hulin 2007-12-17 21:19:56 UTC 
We could possibly add an item to the menu such as "Cycle through aspect ratios" or something.
Comment 8 Patrick Hulin 2007-12-17 22:49:54 UTC 
Created attachment 101150 [details] [review]
Attempt at a patch to fix this per above comment

Breaks aspect ratio support. Can someone take a look and help me out? Thanks.
Comment 9 Patrick Hulin 2007-12-18 03:52:42 UTC 
Actually, aspect ratio support is already broken in SVN - the patch is fine. Not sure why it's not working, GTK is giving a warning - (totem:29712): Gtk-WARNING **: Radio group does not contain an action with value '1'
Comment 10 Bastien Nocera 2008-02-20 17:28:49 UTC 
(In reply to comment #9)
> Actually, aspect ratio support is already broken in SVN - the patch is fine.
> Not sure why it's not working, GTK is giving a warning - (totem:29712):
> Gtk-WARNING **: Radio group does not contain an action with value '1'

It works, fixed in 2.21.93.
Comment 11 André Klapper 2008-08-12 12:19:19 UTC 
I assume last comment refers to the GTK warning...
Patch introduces new strings, hipefully we can get this in early in 2.25.
Comment 12 Bastien Nocera 2008-08-12 13:54:36 UTC 
I'm not really interested in adding a new menu item though, I'd rather the GTK+ bug got fixed instead... Sorry Patrick.
Comment 13 Bastien Nocera 2014-01-26 00:14:36 UTC 
Instead, we'll implement an help overlay (bug 722995).