After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351798 - Zoom 1:2, 1:1 doesn't do anything
Zoom 1:2, 1:1 doesn't do anything
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: GStreamer backend
1.5.x
Other Linux
: Normal normal
: ---
Assigned To: Maintainer alias for GStreamer component of Totem
Maintainer alias for GStreamer component of Totem
: 352804 354636 357489 369843 372938 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-08-17 17:47 UTC by Bastien Nocera
Modified: 2006-11-27 09:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Deletes width_request and height request for tmw_bvw_vbox in totem.glade (669 bytes, patch)
2006-09-11 10:50 UTC, Lubomir Marinov
none Details | Review

Description Bastien Nocera 2006-08-17 17:47:48 UTC
1. Load up a video file
2. Try typing "0", "1" or "2"
And even though the film at those sizes fits on the screen, the window isn't resized at all.
Comment 1 Tim-Philipp Müller 2006-08-18 14:28:42 UTC
This used to work a few days ago, but is indeed broken now. I suspect code changes outside of the GStreamer backend code to be the culprit though.
Comment 2 Bastien Nocera 2006-08-18 14:48:48 UTC
You're probably right, let me test this with the xine-lib backend as well, I think I broke it with the sidebar size changes.
Comment 3 Bastien Nocera 2006-08-25 10:21:59 UTC
*** Bug 352804 has been marked as a duplicate of this bug. ***
Comment 4 Bastien Nocera 2006-09-06 23:21:12 UTC
*** Bug 354636 has been marked as a duplicate of this bug. ***
Comment 5 Lubomir Marinov 2006-09-11 10:25:27 UTC
I fixed the problem locally on my Totem setup by modifying its totem.glade (/opt/gnome/share/totem/totem.glade). I commented out the <property> tags for properties width_request and height_request for the widget with id="tmw_bvw_vbox".
Comment 6 Lubomir Marinov 2006-09-11 10:50:59 UTC
Created attachment 72540 [details] [review]
Deletes width_request and height request for tmw_bvw_vbox in totem.glade

I didn't know if I my previous post had made it clear how I fixed the problem on my system and I thought that it'd be easier to have a patch file. So I've created one that deletes the property values for width_request and height_request on the widget tmw_bvw_vbox.
Comment 7 Bastien Nocera 2006-09-11 10:54:30 UTC
Tim, I can't reproduce this with the xine-lib backend.
Comment 8 Tim-Philipp Müller 2006-09-25 08:56:35 UTC
*** Bug 357489 has been marked as a duplicate of this bug. ***
Comment 9 Chris Rose 2006-10-13 01:01:12 UTC
The attached patch fixes this issue for me. It seems to only occur with the gstreamer backend.
Comment 10 Chris Rose 2006-10-13 01:04:05 UTC
Sorry for the noise -- forgot to say this has been mentioned downstream.

https://launchpad.net/products/totem/+bug/65797
Comment 11 Tim-Philipp Müller 2006-10-13 16:25:26 UTC
> The attached patch fixes this issue for me. It seems to only occur with the
> gstreamer backend.

It fixes the issue for me as well, I just don't really understand why without that patch things work for the xine backend but not the GStreamer backend ...


Comment 12 Bastien Nocera 2006-11-03 14:45:48 UTC
*** Bug 369843 has been marked as a duplicate of this bug. ***
Comment 13 Bastien Nocera 2006-11-03 14:50:39 UTC
2006-11-03  Bastien Nocera  <hadess@hadess.net>

        * data/totem.glade: Patch from Lubomir Marinov to make the "Zoom
        1:2", etc. menu items work again by not setting the width and height
        request on the video widget (Closes: #351798)

Problem is that instead of having the "default" size now for the first-time run
of Totem, we have the minimum size. Works for me anyway.
Comment 14 Bastien Nocera 2006-11-09 13:04:38 UTC
*** Bug 372938 has been marked as a duplicate of this bug. ***
Comment 15 Sebastien Bacher 2006-11-27 09:47:02 UTC
That change seems to break the window resizing when masking the sidebar (open totem, open the sidebar, close the sidebar, the window is much smaller then). Should I open a new bug about that?
Comment 16 Bastien Nocera 2006-11-27 09:56:27 UTC
(In reply to comment #15)
> That change seems to break the window resizing when masking the sidebar (open
> totem, open the sidebar, close the sidebar, the window is much smaller then).
> Should I open a new bug about that?

I guess so, and mention the version of Totem used. I can't reproduce this particular bug (although the first open of the sidebar has some interesting consequences).