After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351680 - Do not mention "gnome" all the time
Do not mention "gnome" all the time
Status: RESOLVED FIXED
Product: gnome-keyring-manager
Classification: Deprecated
Component: general
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: Keyring manager maintainers
Keyring manager maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-16 21:20 UTC by Wouter Bolsterlee (uws)
Modified: 2007-02-11 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
String changes (2.24 KB, patch)
2006-12-14 03:41 UTC, Alexander “weej” Jones
rejected Details | Review
Strings changes 2 (2.40 KB, patch)
2007-02-11 11:05 UTC, Laurent Bigonville
none Details | Review
Strings changes 2(bis) (2.40 KB, patch)
2007-02-11 11:11 UTC, Laurent Bigonville
committed Details | Review

Description Wouter Bolsterlee (uws) 2006-08-16 21:20:37 UTC
gnome-keyring-manager is a standard set of the Gnome desktop. There's no need to put "GNOME" in several of the strings used in the application. Eg. the about box could do better with "Simple management of your keyrings" as the description line.
Comment 1 Alexander “weej” Jones 2006-12-14 03:40:29 UTC
I've done some string changes, but I'm not sure if "Copyright \302\251 2004, 2005 The GNOME Love Project" should be changed. Who is the copyright holder, technically?

I don't really know how these things are done, but I'm sure you don't expect me to do all the translations. Have a patch, anyway.
Comment 2 Alexander “weej” Jones 2006-12-14 03:41:03 UTC
Created attachment 78341 [details] [review]
String changes
Comment 3 Mariano Suárez-Alvarez 2006-12-14 05:54:12 UTC
I'm not sure having Keyrings, capitalized, all over the place is a great idea.
Also, an article is probably needed in strings like "Access denied to Keyring" and others.

Translations are to be done by translators: you rpatch correctly only deals with the English source.

Btw, Alex, please do not change the copyright strings.
Comment 4 Alexander “weej” Jones 2006-12-14 19:20:26 UTC
Do we actually have any official policy, here? Only I'm having a little trouble understanding the rules.

As far as I'm concerned, the word "Keyring" in this context is most definitely a proper noun, and as such should be capitalised.

If we're going to ever call it "GNOME Keyring" at all, we should be consistent and call, e.g. gedit "GNOME Text Editor".

What do you think?
Comment 5 Wouter Bolsterlee (uws) 2006-12-15 08:02:56 UTC
(In reply to comment #4)
> As far as I'm concerned, the word "Keyring" in this context is most definitely
> a proper noun, and as such should be capitalised.

Uh?!

> If we're going to ever call it "GNOME Keyring" at all, we should be consistent
> and call, e.g. gedit "GNOME Text Editor".

There's a difference between Title Case and sentence case. Do not overabuse capitals, we're not German :)
Comment 6 Alexander “weej” Jones 2006-12-15 18:03:18 UTC
OK

I don't really know what I'm doing then. Someone else can take this up.
Comment 7 Mariano Suárez-Alvarez 2007-01-20 21:04:17 UTC
The user should only see "Keyring Manager" (title case) in the window title and such places. When you refer to the keyring daemon, saying GNOME all the time is bad, and "GNOME Keyring daemon is not running" should be "The keyring daemon is not running" and so on. 
Comment 8 Laurent Bigonville 2007-02-11 11:05:12 UTC
Created attachment 82311 [details] [review]
Strings changes 2

String freeze tomorrow, please merge
Comment 9 Laurent Bigonville 2007-02-11 11:11:50 UTC
Created attachment 82313 [details] [review]
Strings changes 2(bis)
Comment 10 Wouter Bolsterlee (uws) 2007-02-11 15:02:11 UTC
2007-02-11  Wouter Bolsterlee  <wbolster@svn.gnome.org>

        * src/gnome-keyring-manager-main-ui.c:
        * src/gnome-keyring-manager-util.c:
        (complain_about_gnome_keyring_bad_result), (gkm_show_about_dialog):

        Do not mention "gnome" all the time. Fixes #351680.
Comment 11 Wouter Bolsterlee (uws) 2007-02-11 15:04:22 UTC
I've sent an announcement to the gnome-i18n list as well.
Comment 12 Wouter Bolsterlee (uws) 2007-02-11 15:07:45 UTC
2007-02-11  Wouter Bolsterlee  <wbolster@svn.gnome.org>

        * data/gnome-keyring-manager.glade:

        Oops, forgot to commit glade file. Really fixes #351680.