GNOME Bugzilla – Bug 351679
Notebooks drawn with extra line below tab in MS-Windows theme
Last modified: 2007-06-10 18:27:37 UTC
Currently, notebook tabs have an extra line drawn underneath them when compared to XP native tabs. See the two attachments to get what I'm talking about.
Created attachment 71050 [details] System.Windows.Forms standard tab control
Created attachment 71051 [details] Gtk Notebook using MS-Windows theme
Do you happen to know off the top of your head if this bug also applies if Windows is using "Classic" theme?
The classic theme bit is drawn properly - that is, it is drawn without a line below the active tab.
Created attachment 77708 [details] [review] Proposed patch I believe this will solve it.
This patch still needs some work. There is no horizontal line drawn across the tabs, up to the current tab. I'll attach a screenshot of Gaim's preferences dialog vs. WinXP's disk drive dialog.
Created attachment 77732 [details] note the differences
Ah, cool.. thanks very much! I'll fix this.
Created attachment 77997 [details] [review] A newer, hopefully better patch. :) Hi dom, could you take a look at this when you have a chance?
Still needs some work. Will attach 2 screenshots to show what I mean.
Created attachment 78133 [details] gaim's preferences dialog, with the highlight drawn improperly
Created attachment 78134 [details] gaim's preferences dialog. the highlighted tab is shifted right
Sorry about that first one. I noticed it last night and fixed it then. I get the second one happening without my patch, but I've got a fix for it ready and I'll post in a minute.
Created attachment 78135 [details] Test Screenshot I also hacked it to display the space in between notebook tabs so that it looks more like Windows. I'm not really sure how this should work for left/right oriented tabs though. Would you like to include this feature?
... or should I open a different bugzilla entry for that feature and apply it separately?
Yeah, that's fine. Your screenshot looks much better.
Created attachment 78137 [details] [review] Newer patch, issues at the top and right edge Hi dom, this patch will fix the top edge (where the yellow stripe was drawing incorrectly).. sorry about that one. It also "fixes" the right edge where the tab's edge and the shadow didn't appear to line up correctly, just by moving the tab a little to the left. I could try to look into how to draw the right tab's edge shadowed if you want, but I'd rather open a new bugzilla entry for that if possible.
I didn't include the tab spacing fix in this patch, btw. Should I do that, or open a new bugzilla entry for it?
Actually, please don't apply that patch. I see something wrong with that right edge fix that doesn't really fix it the way it should.
Created attachment 78161 [details] [review] Newer patch that correctly checks which tab we are rendering The last patch was not correct in how it tried to figure out which tab we are rendering. This patch knows if we are drawing the last tab, and it's able to adjust the width of the last tab accordingly so that the edges line up.
Committed to the GTK+ 2.10 and HEAD branches. Thanks, Cody.