GNOME Bugzilla – Bug 351332
fix implicit function declarations in Evolution code
Last modified: 2013-09-13 00:53:09 UTC
There are quite a few places in the Evolution source code that produce "implicit declaration of function" warnings during compilation. When packaging Evolution for Fedora Core I usually build it with the -Werror-implicit-function-declaration compiler flag (to make the warnings fatal) and then patch the failures. I am filing this bug for two reasons: 1) To get the patch merged upstream (and to get it off my hands!). 2) To encourage Evolution developers to make this compiler flag used by default when building Evolution. To help with the analysis of the patch, I have assembled a list of compiler errors I encountered when building Evolution with the aforementioned flag. The list is ordered to correspond with the ordering of hunks in the patch.
Created attachment 70877 [details] [review] Proposed patch Fixes all missing function declarations in Evolution 2.7.91.
Created attachment 70878 [details] List of implicit function declaration errors
oh my god, i always wanted a patch like that. :-) thanks a lot! harish: *poke* - review?
Note that some of the recently submitted patches on evolution-patches@gnome.org may overlap with this one.
as i wrote on e-h mailing list, let's get this patch in and from that on, please always compile with -Werror-implicit-function-declaration and G_LOG_LEVEL_CRITICAL enabled to both avoid problems on other platforms (e.g. bug 349310) and unusable 2.7.4 releases. this refers to ALL the novell evolution folks compiling evo, not only harish and poornima, but also everybody testing his own patches.
Created attachment 71330 [details] [review] Additional patch for 2.7.92 Found a new one in Evolution 2.7.92. Here's a patch for it.
*** Bug 352708 has been marked as a duplicate of this bug. ***
bug 352708 provides another nice list of all the places where this happens. changing severity as this can trigger crashes on other platforms (see bug 349310).
Created attachment 72335 [details] [review] Proposed patch Evolution 2.8.0 fixed a few of these, so here's a new patch that covers all of the remaining issues in CVS HEAD. It would be great to see this fixed once and for all in Evolution 2.8.1 and 2.9.1. That way I can start on my next goal: make Evolution survive -Werror (as much as possible) by 2.10.
Looks good. Can you pl. attach a ChangeLog before committing it ? Thanks for the patch.
Patch committed with ChangeLog entries. Closing this bug.