GNOME Bugzilla – Bug 350994
sanitise podcast feed names
Last modified: 2018-05-24 11:45:42 UTC
We should strip annoying characters out of podcast feed names. This feed has a newline in its name, which causes some UI weirdness and makes awkward directory names: http://rss.mac.com/diplo1978/iWeb/mad decent radio/mad decent radio/rss.xml
since I opened this bug, the feed has been moved to http://rss.mac.com/diplo1978/iWeb/mad%20decent%20radio%20worldwide/Podcast/rss.xml, and fixed so the title doesn't include a newline.
(rb 0.9.6) This feed has an url (thus a forward slash) in it's title. This results in a subfolder inside the folder where the episodes are stored. http://feeds.feedburner.com/netzklang Don't know if this may be a security issue, but it'd be better to have some escaping for the folder names.
They are not particularly elegant (no real utf-8 handling), but the follwing two patches should a) remove control chars from feed and episode titles and b) do necessary escaping on file and folder names.
Created attachment 77577 [details] [review] patch to add escaping in rb-podcast-manager.c
Created attachment 77578 [details] [review] patch to replace control chars with spaces in rb-podcast-parse.c
re: #2 When the podcast titles have a forward slash, it also prevents rhythmbox from deleting the folder when all the episodes have been deleted. I have this problem with the Rush 24/7 Podcast. Here's the url: http://rss.premiereradio.net/podcast/rushlimb.xml (you can't get any episodes without a password.)
*** Bug 406351 has been marked as a duplicate of this bug. ***
Created attachment 83296 [details] [review] merged and updates Merged and updated to svn
Podcast URL http://download.br-online.de/podcast/kalenderblatt/cast.xml adds a newline (?) to the podcast title and directory.
Pretty old bug. For what it's worth, I've fixed totem-pl-parser to remove new lines and spaces from titles. The patch probably needs to be updated to the current podcast parsing code though.
I've got Rhythmbox 0.11.5 which has still this bug. /dev/radio Podcast at http://ulm.ccc.de/dev/radio/ creates a subfolder "dev".
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/224.