After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350974 - Places sidebar should have "Network Servers"
Places sidebar should have "Network Servers"
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Sidebar
2.15.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 449563 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-08-11 22:35 UTC by Federico Mena Quintero
Modified: 2008-03-31 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
nautilus-350974-network-servers-in-places-sidebar.diff (1.22 KB, patch)
2006-08-11 22:36 UTC, Federico Mena Quintero 		none Details | Review
sidebar_network-protocol.patch (740 bytes, patch)
2008-03-19 13:05 UTC, Sebastian Dröge (slomo) 		none Details | Review
Alternative patch (794 bytes, patch)
2008-03-19 14:04 UTC, Vincent Untz 		committed Details | Review

Description Federico Mena Quintero 2006-08-11 22:35:06 UTC 
The attached patch adds a "Network Servers" item to the Places sidebar, to be consistent with GtkFileChooser and GtkFileSystemGnomeVFS.
Comment 1 Federico Mena Quintero 2006-08-11 22:36:58 UTC 
Created attachment 70752 [details] [review]
nautilus-350974-network-servers-in-places-sidebar.diff
Comment 2 Sebastian Dröge (slomo) 2008-03-19 13:05:14 UTC 
Created attachment 107608 [details] [review]
sidebar_network-protocol.patch

updated patch for nautilus 2.22
Comment 3 Vincent Untz 2008-03-19 14:02:36 UTC 
The patch should use NAUTILUS_ICON_NETWORK instead of the string for the icon name. Also, we use Network instead of Network Servers everywhere else.
Comment 4 Vincent Untz 2008-03-19 14:04:10 UTC 
Created attachment 107615 [details] [review]
Alternative patch

For convenience, here's the patch I had.
Comment 5 Sebastian Dröge (slomo) 2008-03-19 14:56:42 UTC 
Ok, Alex agreed to commit this after trunk went in 2.23 direction... will commit then :)
Comment 6 Cosimo Cecchi 2008-03-19 17:43:33 UTC 
Setting right patch status as for last comment.
Comment 7 Cosimo Cecchi 2008-03-29 14:53:47 UTC 
Committed to trunk now that Nautilus has been branched. Closing as FIXED.

2008-03-29  Cosimo Cecchi  <cosimoc@gnome.org>

	* src/nautilus-places-sidebar.c: (update_places):
	Show network servers in Places sidebar. Patch by Vincent Untz.
	(#350974).
Comment 8 A. Walton 2008-03-31 14:09:21 UTC 
*** Bug 449563 has been marked as a duplicate of this bug. ***