After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350962 - Filing cabinet icon is not recognizable
Filing cabinet icon is not recognizable
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: general
2.15.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-11 21:31 UTC by Federico Mena Quintero
Modified: 2010-05-11 10:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
nautilus-better-icons-for-launchers-and-windows.diff (3.13 KB, patch)
2006-08-11 21:37 UTC, Federico Mena Quintero
none Details | Review
nautilus-better-icons-for-launchers-and-windows.patch (1.26 KB, patch)
2008-05-01 03:28 UTC, Hans Petter Jansson
none Details | Review
nautilus-better-icons-for-launchers-and-windows.patch (2.19 KB, patch)
2008-05-01 05:01 UTC, Hans Petter Jansson
none Details | Review

Description Federico Mena Quintero 2006-08-11 21:31:24 UTC
When we did some user testing at Novell, users had better recognition for the "folder" icon in Nautilus launchers and file windows, instead of the default "filing cabinet" one.

The attached patch makes Nautilus use "gnome-fs-directory" as the icon for these items.
Comment 1 Federico Mena Quintero 2006-08-11 21:37:28 UTC
Created attachment 70747 [details] [review]
nautilus-better-icons-for-launchers-and-windows.diff
Comment 2 Hans Petter Jansson 2008-05-01 03:28:50 UTC
Created attachment 110205 [details] [review]
nautilus-better-icons-for-launchers-and-windows.patch

Same patch, rebased for Nautilus 2.22.2.
Comment 3 A. Walton 2008-05-01 03:36:32 UTC
Why not "folder" instead of "gnome-fs-directory", per the Icon Naming Specification?
Comment 4 Hans Petter Jansson 2008-05-01 04:03:33 UTC
No idea. Is "gnome-fs-directory" not permissible?
Comment 5 A. Walton 2008-05-01 04:08:20 UTC
I'm not saying it's not permissible, but it seems that we're trying to head that way, and it's somewhat counterproductive to go back here.

In fact, it should probably even be NAUTILUS_ICON_FOLDER (per the define in nautilus-icon-names.h), so that we don't have to hunt it down if it needs to change again.
Comment 6 Hans Petter Jansson 2008-05-01 05:01:22 UTC
Created attachment 110208 [details] [review]
nautilus-better-icons-for-launchers-and-windows.patch

Revised patch.
Comment 7 A. Walton 2008-05-01 05:20:28 UTC
This looks fine for trunk to me (definitely looks better than the filing cabinet icon). 
Comment 8 Christian Neumair 2008-05-03 12:51:45 UTC
Confirming.

I am not sure whether this change is a good idea.

Users may use the icon to distinguish browser windows from spatial windows.

And if decide to use a folder icon, we should also display special icons for special locations (i.e. computer:///). See nautilus-spatial-window.c how this would work.

I am CCing the usability team for some feedback.
Comment 9 Matthew Paul Thomas (mpt) 2008-05-07 20:42:40 UTC
I agree with using the location-specific icon. It's strange for the current location to change a browser window's title, but not its icon. The main drawback I can think of is that the icon would change rapidly as you navigate through the hierarchy. I think using the icon to distinguish browser windows is not nearly as useful as using the presence of the toolbar, location bar, and/or side pane to recognize those windows. (Though as full disclosure, we're considering removing the Window List in Ubuntu, which would make a window's overall appearance more important for recognition than either its icon or its title.)

Konqueror's icon is location-specific, regardless of whether it's displaying a filesystem item or a Web page. Epiphany's and Firefox's icons are static. Mac OS X Finder's browser icon is location-specific, though that's unsurprising because the icon is a draggable proxy for the current location. I'm unable to test Windows Explorer's behavior at the moment.
Comment 10 Vincent Untz 2009-05-06 12:25:49 UTC
FWIW, I opened bug 581584 to try to change the metaphor in the icon theme.
Comment 11 Cosimo Cecchi 2010-05-11 10:51:39 UTC
This is OBSOLETE now that bug #613733 is fixed. Closing, feel free to reopen if I missed something.