Created attachment 70716 [details]
my take on an icon

This is my take on an GParted tango icon and my first tango icon ever.

It is a slightly modified version of a tango stock icon.

looks cool, thanks :)

The partition diagram on top of the HDD looks too flat IMHO. Also, is the HDD itself based off the icon from the Tango base theme? This would probably generate licensing issues.

Also, the icon should be available in all sizes (16, 22, 24, 32 pixel bitmap as well as scalable vector svg)

Proposing gparted for on of the next Tango Fridays¹

[1] http://tango.freedesktop.org/Tango_Fridays

thanks and please keep us posted :)

any news on this one?

Created attachment 88588 [details]
gparted tango

what do you think?

The light gray part (bottom right is too much like the HDD itself IMHO.

Otherwise, nice!

Created attachment 88650 [details]
gparted tango slight mod no1

you can see a preview of the versions by following this link http://eska-art.de/blog/wp-content/uploads/2007/05/gparted_tango_varianten.png

Created attachment 88651 [details]
gparted tango slight mod no2

for preview see the previous post

I suggest sending those icons to the Tango mailing list and/or visiting #tango on freenode, to let the Tango artists review the icons.

(In reply to comment #10)
> I suggest sending those icons to the Tango mailing list and/or visiting #tango
> on freenode, to let the Tango artists review the icons.
> 

i'm on #tango (needcoffee)...the artists see the 1st version and i tell them that i upload it to bugzilla to see what the devs think :)

I would lighten up the harddisk portion a bit. It's a little too black, and causes some useful contrast to be lost between the circle graph and the disk.

Wow, this one looks great, amazing work as usual Sebastian!
Do we need a patch to install it properly as well?

Created attachment 118873 [details] [review]
Patch

Small patch to make use of the themed app icon from hicolor (launcher, window icons, about dialog)

Created attachment 118874 [details]
data dir

data/icon folder to be used with the patch above. This uses the newest (very nice!) version of the icons posted to the tango mailing list.

Extract it in the gparted/ root and remove the pixmaps/ folder.

Note: the .desktop file can also be moved to data/ to match other gnome project layouts but I tried to keep the changes to a minimum right now.

Thank you for the patch Michael.

My understanding of how gnome themes are supported is minimal.

Would you be able to point me to some documentation regarding how themed icons should be supported?

Ok, long story short:

Generally we follow the fdo icon theme spec [1]. There's two cases:

a) launcher/window/logo icons: those often went as a single-size icon into share/pixmaps/$appname in the past. We now put them in various sizes into the apps context of the global hicolor theme (share/icons/hicolor/$size/apps/$appname). The hicolor theme acts as a fallback, so even if you use the gnome icon theme something like that on your desktop, the icons from hicolor will work.

b) app-specific icons: icons for special toolbar icons etc (not part of gtk stock or gnome-icon-theme), those were mostly installed into share/pixmaps/$appname/ or share/$appname in the past. Now, we put them into a private hicolor dir (share/$appname/icons/hicolor) and register share/$appname/icons as an icon path. See [2].

In the app itself we just use the icon by name (instead of manually creating a pixmap or loading the icon using a hardcoded path etc).

In gparted, only a) is used right now btw, the patch should take care of this. Extending this to also do b) would be easy in the future (e.g. new icons need to be added to the data/icons/ dir and listed in the "private" section of the makefile, plus a call of gtk_icon_theme_append_search_path somewhere as described in [2].

[1] http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
[2] http://live.gnome.org/ThemableAppSpecificIcons

Michael,

Thank you for the explanation and links.  And of course for the patch :-)

This change has been applied to the gnome SVN repository for inclusion in the next release of GParted (0.4.0).


Sebastian,

   Thank you for the cool icons.

   Would you be agreeable to having the icon, your name, and your email address added to the GParted Artwork page?
   http://gparted.sourceforge.net/artwork.php

Regards,
Curtis Gedak

(In reply to comment #18)
> 
> Sebastian,
> 
>    Thank you for the cool icons.
>

My pleasure.

>    Would you be agreeable to having the icon, your name, and your email address
> added to the GParted Artwork page?
>    http://gparted.sourceforge.net/artwork.php
> 

Sure, that would be fine.

> 
best,

Sebastian

Thank you for the quick response Sebastian.

The GParted Artwork page has been updated.

Closing this bug.

*** Bug 573648 has been marked as a duplicate of this bug. ***