After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350741 - [faac] Wrong bitrate set
[faac] Wrong bitrate set
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-10 13:32 UTC by Michal Benes
Modified: 2006-08-10 17:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Set bitrate correctly (894 bytes, patch)
2006-08-10 13:34 UTC, Michal Benes 		committed Details | Review

Description Michal Benes 2006-08-10 13:32:55 UTC 
According to faaccfg.h, property bitRate means bitRate of a single AAC channel. Thus this variable should be set to
<plugin bitrate property> / <number of channels>
to get what we want.
Comment 1 Michal Benes 2006-08-10 13:34:46 UTC 
Created attachment 70642 [details] [review]
Set bitrate correctly

This patch configure faac encoder to produce the bitrate we want. Also there is a small coding style fix.
Comment 2 Tim-Philipp Müller 2006-08-10 17:12:43 UTC 
Committed, thanks!

 2006-08-10  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: Michal Benes  <michal.benes at itonis tv>

       * ext/faac/gstfaac.c: (gst_faac_configure_source_pad):
         Bitrate in the faac structure is per output channel,
         not total bitrate (#350741).