Created attachment 70639 [details] [review]
Proposed patch

This patch includes some code from a previous patch (http://bugzilla.gnome.org/attachment.cgi?id=70635): it adds selected/unselected string for a list label.

Since we're close to the GNOME 2.16 deadline, I'm a bit uneasy about changes to the core orca logic right now.  For this particular patch, can we accomplish the same objective if you:

Remove the isSameObject check from orca.py:setLocusOfFocus and keep orca.py:setLocusOfFocus the way it was.  This will let us keep track of the last "real" object we know of that really was the locusOfFocus.  For all we know, the last object (even if it was technically the "same" object) may have gone defunct.

At the beginning of default.py:locusOfFocusChanged, check for "util.isSameObject(event.source, orca_state.locusOfFocus)" and return if the value is true.  Also get rid of this little bit of code further down in default.py:locusOfFocusChanged: 

        if newParent and (oldParent == newParent):
            state = newParent.state
            if state.count(atspi.Accessibility.STATE_MANAGES_DESCENDANTS) \
                and (oldLocusOfFocus.index == newLocusOfFocus.index) \
                and (oldLocusOfFocus.name == newLocusOfFocus.name):
                    return

Moving the isSameObject decision from orca.py to default.py gives the script the power to make decision about what to do if the focus for the same exact object was updated.

BTW, since the locus of focus can be None, you'll also need to add some additional logic to isSameObject to check if either obj1 or obj2 is None.  Something like this might work:

    if (obj1 == obj2):
        return True
    elif (not obj1) or (not obj2):
        return False
    ...

Will

Created attachment 70715 [details] [review]
Reworked patch

Reworked patch as requested in comment #2:
  - removed the isSameObject check from orca.py:setLocusOfFocus and keeped
orca.py:setLocusOfFocus the way it was
  - added check for
"util.isSameObject(oldLocusOfFocus, newLocusOfFocus)" at the beginning of default.py:locusOfFocusChanged
  - removed the suggested code from default.py:locusOfFocusChanged
  - added additional check in isSameObject to check if obj1 or obj2 is None

With the latest Orca from CVS, without this patch, list items are spoken for 4 times, comboboxes, textboxes and buttons are spoken twice (in Open dialog window) when they get focus.

Fixed in the development version. The fix will be available in the next major release (0.2.9). Thank you for your bug report and patch!