After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350738 - [ffvideoscale] GStreamer-Critical when pixel-aspects-ratio was set on both pads
[ffvideoscale] GStreamer-Critical when pixel-aspects-ratio was set on both pads
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-10 13:10 UTC by Michal Benes
Modified: 2008-10-08 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Set source pixel-aspect-ratio only if it was not set before (633 bytes, patch)
2006-08-10 13:14 UTC, Michal Benes 		rejected Details | Review

Description Michal Benes 2006-08-10 13:10:46 UTC 
In the case that pixel-aspect-ratio is set to both input and output caps, ffvideoscale reports GStreamer-Critical when checking IS_MUTABLE(outstructure).
The problem is that ffvideoscale allways computes pixel-aspect-ratio for source caps and sets them to the src pad. This should probably be done only if the output pad has not pixel-aspect-ratio set.
Comment 1 Michal Benes 2006-08-10 13:14:24 UTC 
Created attachment 70638 [details] [review]
Set source pixel-aspect-ratio only if it was not set before

This patch will set pixel-aspect-ratio to output pads only if they were not set before. Another approach would be to copy caps negotiation from videoscale (plugins-base) but this is a bit more complicated
Comment 2 Edward Hervey 2006-10-07 07:27:10 UTC 
I was going to commit this... but it should in fact have proper negotiation as you mentionned. It's not THAT complicated to do here ,especially since you have an existing -base plugin (videoscale) to base yourself on.
Comment 3 Mark Nauwelaerts 2008-10-08 13:16:48 UTC 
This bug no longer applies to rewritten ffvideoscale
(see also bug #504056).