GNOME Bugzilla – Bug 350339
Add option to change 'mq' image size when exporting images to HTML gallery
Last modified: 2018-07-12 00:05:15 UTC
As it is, when exported to 'Html gallery', images are unusably small, 480x320. An option should be available to change image size for images that are opened after clicking thumbnails.
Created attachment 70424 [details] [review] adds spinbox that defines quality for 'mq' images for HtmlGallery Spinbox is active only for HTML gallery. Also stylesheet is modified to not break when image exceeds some 630px in size. (Stylesheet is also modified to not refer to some .png's that do not exists).
patch review: patch #70424 for bug #350339 * apply and compile * on the css file: (I'm not a pro on css, so I can be wrong) - why commenting parts of the css, even if the images don't come with the f-spot distribution ? those missing images do not cause any displaying issue... - why do you change the width from 100% to 630px ? It's probably better to restrict the max size of the mq image, no ? Think about people with very large displays... * FolderExport.cs: - In HandleHtmlGallery, you change the Sensitiveness of the spin button. I'd prefer changing the Visibility instead. - You need to ensure that the mq size is lower than the resized HQ. * f-spot.glade: - you add a tooltip for the Original export. I know that it's useful, but is'nt it out of scope of the bug subject ? - 'Resize images' is not the best label for the size of middle quality images. It's a bit confusing with the next resize. - The new label for the old resize is now strange when e.g. you 'save images only'. need to be cleaned. - don't set the default value that big (800), use preferably the old default 480. Set also a more reasonable highest value. Like 800 or 1024, but not 10000. MQ images are not only defined by the size of the screen, but also by the bandwith it needs to transport them (and the time to display them).
Created attachment 71793 [details] [review] implent configurable mq image size for htmlgallery - css: when images are not commented out, they still generate server requests; they also pollute server logs with 404s. - css: if width is not limited, header will be often too wide (as wide as possible). It's not pretty and ~630px looked 'good enough' on 1600x1200 too. - visibility/sensitivity: implemented, effect is a bit weird and I can't figure out where I should change 'fill/expand' settings to just make lower setting jump up without filling space. - mq vs. hq: This would be much trouble for little use, I think. Would be 'nice polishing' but ultimately not worth it. - tooltip for original: dropped - 'resize images': changed to 'Resize standard images'. Just can't think of more appropriate term. - resize "originals": dropped - default image sizes: default to 600 as compromise, it's really really small. ~85% of web users are at 1024x768 now and even larger percentage surfs with window maximized. We're also showing images, not random blotches. - as for setting maximum, maximum size is already capped at what file really is (no upsizing) and file display size choice should really be user's.
Created attachment 71823 [details] [review] Corrected folder.export.patch for latest cvs sources As the patch (id=71793) does not work for me with the newest CVS (I tried it with 0.1.11, 0.1.12 and 0.2.0 too but it does not work neither) I applied the patch manually. I don't know if I made something wrong or whatever (the patch worked yesterday), but here is the new one. It works for me for the latest cvs sources.
Paul I suspect is isn't working becaus the glade part of the patch ended up in the wrong place can someone please check the xml and update the patch so that it applies to the correct part of the glade file?
F-Spot has moved to https://github.com/f-spot/f-spot/issues If this Bugzilla ticket is still valid in a recent version of F-Spot, please feel free to post this topic as a ticket in the F-Spot project on GitHub. Closing this report as WONTFIX as part of Bugzilla Housekeeping as we are planning to shut down GNOME Bugzilla in favor of GNOME Gitlab.