GNOME Bugzilla – Bug 350311
[playbin2] support for subpicture subtitles
Last modified: 2009-05-21 17:48:57 UTC
In bug 350044 Tim wrote: `` As for VOB subtitle support in totem, that mostly needs implementing in playbin. There needs to be an image mixer (but preferably not videomixer, since we really don't want to convert the input video stream into AYUV just to blit the subtitles on top and then convert back again) etc. Also, mpegdemux/dvddemux need to send newsegment updates as events to fill in the gaps, and the videomixer needs to handle this properly. '' This bug report aims to track progress on this.
*** Bug 439960 has been marked as a duplicate of this bug. ***
Does anyone work for subtitle support in DVD's ?
As per Bastien's comment http://bugzilla.gnome.org/show_bug.cgi?id=344415#c7 I have created a tracker bug to make it easier to keep track of the various issues preventing proper DVD support in Totem-Gstreamer. The bug can be found here: Bug 502609 – [Tracker] GStreamer DVD Support in Totem I hope nobody minds me taking the liberty to create this.
*** Bug 537220 has been marked as a duplicate of this bug. ***
This should be closed maybe now that we have the new resindvd plugin ?
> This should be closed maybe now that we have the new resindvd plugin ? No, we still need general - support for external subtitles in vob format, and - support subpicture subtitles embedded in files (matroska/quicktime/mpeg) Should move the bug over to playbin2 though I guess.
(In reply to comment #6) > > This should be closed maybe now that we have the new resindvd plugin ? > > No, we still need general > > - support for external subtitles in vob format, and > > - support subpicture subtitles embedded in files (matroska/quicktime/mpeg) > Embedded subtitles are already supported no? I think they are, at least for matroska. > Should move the bug over to playbin2 though I guess. > > >
Yes, embedded subtitles are supported but not embedded subpicture subtitles :) I guess bug #570753 is a duplicate of this one too...
*** Bug 570753 has been marked as a duplicate of this bug. ***
As I've said in bug #570753 already we should probably create a subtitlebin that takes video and subtitle input and outputs video with subtitles. This way we could support the plaintext subtitles, subpicture subtitles and subtitle renderers (like assrender).
commit 9bf8277d135e818ce502ad1dd9956929382f136c Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Tue Mar 24 18:29:28 2009 +0100 playbin2: add more support for subpictures commit e7b382c6a9e1bec3cf7772989a9093818a112de9 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Tue Mar 24 17:12:53 2009 +0100 playbin2: first support for subpictures Add beginnings of subpicture support.
Are external subpicture subtitles, supposed to work now or does these need to be supported in Totem first? These are the errors I get when I try to open video with vobsub subtitles: 0:00:00.964399403 16661 0x9229490 ERROR totem /home/sa/Temp/totem/totem-svn/src/backend/bacon-video-widget-gst-0.10.c:331:bvw_error_msg: message = Internal data stream error. 0:00:00.964446998 16661 0x9229490 ERROR totem /home/sa/Temp/totem/totem-svn/src/backend/bacon-video-widget-gst-0.10.c:333:bvw_error_msg: domain = 3719 (gst-stream-error-quark) 0:00:00.964456521 16661 0x9229490 ERROR totem /home/sa/Temp/totem/totem-svn/src/backend/bacon-video-widget-gst-0.10.c:334:bvw_error_msg: code = 1 0:00:00.964466123 16661 0x9229490 ERROR totem /home/sa/Temp/totem/totem-svn/src/backend/bacon-video-widget-gst-0.10.c:335:bvw_error_msg: debug = gstmpegdemux.c(2521): gst_flups_demux_loop (): /GstPlayBin2:play/GstURIDecodeBin:uridecodebin1/GstDecodeBin2:decodebin20/GstMpegPSDemux:mpegpsdemux0: Can't push EOS downstream 0:00:00.964476879 16661 0x9229490 ERROR totem /home/sa/Temp/totem/totem-svn/src/backend/bacon-video-widget-gst-0.10.c:336:bvw_error_msg: source = <mpegpsdemux0> 0:00:00.964494464 16661 0x9229490 ERROR totem /home/sa/Temp/totem/totem-svn/src/backend/bacon-video-widget-gst-0.10.c:337:bvw_error_msg: uri = file:///home/sa/Media/Movies/Ninotchka%20(1939)/Ninotchka.avi ** Message: Error: Internal data stream error. gstmpegdemux.c(2521): gst_flups_demux_loop (): /GstPlayBin2:play/GstURIDecodeBin:uridecodebin1/GstDecodeBin2:decodebin20/GstMpegPSDemux:mpegpsdemux0: Can't push EOS downstream
I have some local commits to push after we thaw that add support for DVD subpictures in MPEG-PS streams to mpegpsdemux. With that in place, the subpictures can be rendered by playbin/playbin2, but there are a few more pieces missing: * external vobsub also requires the .idx in order to get the colour palette to use and some other info. * playbin2 needs to group the subpicture streams together and expose them as selectable subtitle streams for the players.