GNOME Bugzilla – Bug 350304
handle databases and playlists from the future gracefully
Last modified: 2009-05-03 21:37:02 UTC
What were you doing when the application crashed? Just ran rhythmbox-client from cvs snapshot of toaday (7 Aug 06) Distribution: Ubuntu 6.10 (edgy) Gnome Release: 2.15.90 2006-07-24 (Ubuntu) BugBuddy Version: 2.15.90 Memory status: size: 62418944 vsize: 0 resident: 62418944 share: 0 rss: 22396928 rss_rlim: 0 CPU usage: start_time: 1154968585 rtime: 0 utime: 158 stime: 0 cutime:145 cstime: 0 timeout: 13 it_real_value: 0 frequency: 6 Backtrace was generated from '/usr/bin/rhythmbox' (no debugging symbols found) Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1". (no debugging symbols found) [Thread debugging using libthread_db enabled] [New Thread -1209075520 (LWP 22050)] [New Thread -1230668896 (LWP 22060)] (no debugging symbols found) 0xffffe410 in __kernel_vsyscall ()
+ Trace 70052
Thread 2 (Thread -1230668896 (LWP 22060))
The only g_assert_not_reached checks I can see in rhythmdb_tree_parser_start_element are related to the version number in rhythmdb.xml. What does 'head -n 3 ~/.gnome2/rhythmbox/rhythmdb.xml' say?
(((baptiste@linbox)))-> head -n 3 ~/.gnome2/rhythmbox/rhythmdb.xml <?xml version="1.0" standalone="yes"?> <rhythmdb version="1.3"> <entry type="song">
Did this occur when you ran rhythmbox-client without RB already running, and with an un-installed build or non /usr prefix? If so this was caused by 1) rhythmbox-client attemps to laod RB if it's not already running 2) the dbus service file installed under /lib was from your distro-installed version of RB, so it started that 3) RB doesn't like encoutnering rhythmdb.xml files newer than it understands, causing the assertion. We should handle this better, which probably means displaying an error dialog and then quitting.
*** Bug 350765 has been marked as a duplicate of this bug. ***
*** Bug 350657 has been marked as a duplicate of this bug. ***
*** Bug 351754 has been marked as a duplicate of this bug. ***
*** Bug 352511 has been marked as a duplicate of this bug. ***
Created attachment 71901 [details] [review] patch? this just throws up an error dialog when an unsupported database version is read, then disables saving so it won't destroy the database on shutdown.
*** Bug 354524 has been marked as a duplicate of this bug. ***
*** Bug 354593 has been marked as a duplicate of this bug. ***
*** Bug 355374 has been marked as a duplicate of this bug. ***
*** Bug 355527 has been marked as a duplicate of this bug. ***
*** Bug 356385 has been marked as a duplicate of this bug. ***
Looks fine to me. I think that in all the db upgrades so far except one, older versions would have handled it fine - adding new metadata and/or URI canonicalisation. Perhaps we should have a "load anyway" option.
I've committed the patch, but I think there's still more to do. I'm downgrading the severity.
*** Bug 357304 has been marked as a duplicate of this bug. ***
*** Bug 360113 has been marked as a duplicate of this bug. ***
confirming as we have lots of duplicates...
*** Bug 361419 has been marked as a duplicate of this bug. ***
*** Bug 362269 has been marked as a duplicate of this bug. ***
*** Bug 362296 has been marked as a duplicate of this bug. ***
*** Bug 364819 has been marked as a duplicate of this bug. ***
*** Bug 374465 has been marked as a duplicate of this bug. ***
*** Bug 375212 has been marked as a duplicate of this bug. ***
We also need to handle playlist files from the future. Currently, an auto playlist using a property or comparison operator that was added in a future version will cause an assertion failure in rhythmdb_query_deserialize.
*** Bug 378029 has been marked as a duplicate of this bug. ***
*** Bug 378044 has been marked as a duplicate of this bug. ***
*** Bug 378045 has been marked as a duplicate of this bug. ***
*** Bug 379202 has been marked as a duplicate of this bug. ***
*** Bug 380430 has been marked as a duplicate of this bug. ***
*** Bug 382806 has been marked as a duplicate of this bug. ***
*** Bug 384159 has been marked as a duplicate of this bug. ***
*** Bug 389334 has been marked as a duplicate of this bug. ***
*** Bug 389660 has been marked as a duplicate of this bug. ***
*** Bug 390546 has been marked as a duplicate of this bug. ***
*** Bug 391225 has been marked as a duplicate of this bug. ***
*** Bug 391227 has been marked as a duplicate of this bug. ***
*** Bug 391228 has been marked as a duplicate of this bug. ***
*** Bug 391230 has been marked as a duplicate of this bug. ***
*** Bug 391232 has been marked as a duplicate of this bug. ***
*** Bug 391234 has been marked as a duplicate of this bug. ***
*** Bug 391239 has been marked as a duplicate of this bug. ***
*** Bug 391260 has been marked as a duplicate of this bug. ***
*** Bug 391420 has been marked as a duplicate of this bug. ***
*** Bug 391760 has been marked as a duplicate of this bug. ***
*** Bug 391761 has been marked as a duplicate of this bug. ***
*** Bug 392156 has been marked as a duplicate of this bug. ***
*** Bug 392637 has been marked as a duplicate of this bug. ***
*** Bug 392954 has been marked as a duplicate of this bug. ***
*** Bug 394936 has been marked as a duplicate of this bug. ***
*** Bug 397289 has been marked as a duplicate of this bug. ***
*** Bug 397718 has been marked as a duplicate of this bug. ***
*** Bug 401238 has been marked as a duplicate of this bug. ***
*** Bug 401359 has been marked as a duplicate of this bug. ***
*** Bug 402615 has been marked as a duplicate of this bug. ***
*** Bug 403442 has been marked as a duplicate of this bug. ***
*** Bug 404084 has been marked as a duplicate of this bug. ***
*** Bug 404974 has been marked as a duplicate of this bug. ***
*** Bug 406517 has been marked as a duplicate of this bug. ***
*** Bug 406578 has been marked as a duplicate of this bug. ***
*** Bug 407499 has been marked as a duplicate of this bug. ***
*** Bug 407889 has been marked as a duplicate of this bug. ***
*** Bug 414037 has been marked as a duplicate of this bug. ***
*** Bug 414302 has been marked as a duplicate of this bug. ***
*** Bug 418196 has been marked as a duplicate of this bug. ***
*** Bug 418312 has been marked as a duplicate of this bug. ***
*** Bug 418313 has been marked as a duplicate of this bug. ***
*** Bug 420061 has been marked as a duplicate of this bug. ***
*** Bug 421795 has been marked as a duplicate of this bug. ***
*** Bug 427555 has been marked as a duplicate of this bug. ***
*** Bug 429301 has been marked as a duplicate of this bug. ***
*** Bug 431646 has been marked as a duplicate of this bug. ***
*** Bug 433464 has been marked as a duplicate of this bug. ***
*** Bug 436973 has been marked as a duplicate of this bug. ***
*** Bug 437773 has been marked as a duplicate of this bug. ***
*** Bug 447693 has been marked as a duplicate of this bug. ***
*** Bug 444794 has been marked as a duplicate of this bug. ***
*** Bug 448744 has been marked as a duplicate of this bug. ***
*** Bug 449345 has been marked as a duplicate of this bug. ***
*** Bug 450239 has been marked as a duplicate of this bug. ***
*** Bug 455394 has been marked as a duplicate of this bug. ***
*** Bug 459865 has been marked as a duplicate of this bug. ***
*** Bug 474186 has been marked as a duplicate of this bug. ***
*** Bug 484352 has been marked as a duplicate of this bug. ***
*** Bug 492436 has been marked as a duplicate of this bug. ***
No duplicates for 18 months now. => Closing as OBSOLETE.