After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350278 - [rtpmp2tdepay] Add support for proprietary headers
[rtpmp2tdepay] Add support for proprietary headers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 0.10.6
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-07 14:19 UTC by Thijs Vermeir
Modified: 2007-03-02 12:16 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Proprietary header patch (8.72 KB, patch)
2006-08-07 14:20 UTC, Thijs Vermeir 		reviewed Details | Review
patch without extra indendation (3.35 KB, patch)
2006-08-08 09:28 UTC, Thijs Vermeir 		committed Details | Review

Description Thijs Vermeir 2006-08-07 14:19:01 UTC 
Many hardware encoders use on top of UDP/RTP a supplementairy header. They do this with 2 purposes.
1. give optional information to the decoder
2. prevent a standard decoder to play there stream ( and so increase sales on there own decoders)

GStreamer can support a lot of these decoders just by skipping these headers. If you don't use this option nothing changes.
Comment 1 Thijs Vermeir 2006-08-07 14:20:27 UTC 
Created attachment 70392 [details] [review]
Proprietary header patch

With this patch GStreamer can support many proprietary headers.
Comment 2 Tim-Philipp Müller 2006-08-08 08:07:27 UTC 
Could you please make a new patch that doesn't involve format changes of unrelated code? These changes won't last anyhow, since our code (*.c files) will be indented automatically on commit using gst-indent (~/gstreamer/tools/gst-indent)
Comment 3 Thijs Vermeir 2006-08-08 09:28:59 UTC 
Created attachment 70469 [details] [review]
patch without extra indendation

New patch without extra idendation, also a little better implementation.
Comment 4 Wim Taymans 2007-03-02 12:16:28 UTC 
        Patch by: Thijs Vermeir <thijsvermeir at gmail dot com>

        * gst/rtp/gstrtpmp2tdepay.c: (gst_rtp_mp2t_depay_class_init),
        (gst_rtp_mp2t_depay_init), (gst_rtp_mp2t_depay_process),
        (gst_rtp_mp2t_depay_set_property),
        (gst_rtp_mp2t_depay_get_property):
        * gst/rtp/gstrtpmp2tdepay.h:
        Add support to strip off proprietary headers. Fixes #350278.