After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350233 - Orca should better support Liferea application.
Orca should better support Liferea application.
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
0.2.x
Other All
: Normal enhancement
: FUTURE
Assigned To: Rich Burridge
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-07 07:52 UTC by Javier
Modified: 2007-01-03 18:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Orca's script for better support Liferea application. (5.40 KB, text/plain)
2006-11-30 13:46 UTC, Javier
  Details
Revised version of the patch. (6.65 KB, patch)
2006-12-01 21:26 UTC, Rich Burridge
none Details | Review
Reworked patch (6.65 KB, patch)
2007-01-03 10:20 UTC, Javier
none Details | Review

Description Javier 2006-08-07 07:52:22 UTC
Currently, in the Liferea application (http://liferea.sourceforge.net) there are accessibility issues.
Orca needs to provide a script to try to solve these issues.

Issues are in the comments.
Comment 1 Willie Walker 2006-08-07 13:49:15 UTC
Here's some additional information from Javier from orca-list@gnome.org:

http://mail.gnome.org/archives/orca-list/2006-August/msg00011.html

"One of issues that I have found, is on the button near statusbar, that
is unlabeled. This button toggles working online/offline withLiferea.
When you click it, the information of the statusbar changes indicating
the new status.

My question are: What do you think Orca should speak/braille here? I
have thought "work online/offline button"
should Orca announce the status when this button gains focus?
or only whenever it changes."

Comment 2 Javier 2006-08-08 12:16:44 UTC
The button has two images to show the status of "working mode". Since no one of this images has a description,
We can speak/braille here "online/offline button" until these images has a description in Liferea application.
Is there another way to detect this image change? I don't think so....
Comment 3 Javier 2006-08-09 12:11:28 UTC
Another issue is with the headlines table tree. When this table gets focus, the locus of focus is the table column header.
If you press down arrow to read the rest of the content the locus of focus keeps in table column header and doesn't change to the other rows in the table.
Comment 4 Willie Walker 2006-10-15 00:25:53 UTC
Add accessibility keyword.  Apologies for spam.
Comment 5 Rich Burridge 2006-10-17 23:48:58 UTC
I've filed a bug against Liferea for the first problem submitted 
(online/offline button not accessible). See:

http://sourceforge.net/tracker/index.php?func=detail&aid=1579316&group_id=87005&atid=581684

I'm adjusting the summary of this bug to show that it's currently blocked
against this.

This is one of several Orca bugs where we possibly could work around it via
scripting, but we prefer that the maintainers of the application in question
try to fix their problem.

If we receive an Orca liferea script fixing this and the other problem reported,
then we'll be happy to accept it.
Comment 6 Rich Burridge 2006-10-17 23:53:11 UTC
I've filed a second bug against Liferea for the problem reported
in comment #3 (problems with headlines table). See:

http://sourceforge.net/tracker/index.php?func=detail&aid=1579318&group_id=87005&atid=581684
Comment 7 Rich Burridge 2006-10-21 00:59:55 UTC
Looks like Lars has just fixed the Liferea online/offline button problem
in  versions 1.0.24 and 1.1.7 of Liferea.
Comment 8 Javier 2006-11-30 13:39:28 UTC
Checking the latest 1.0.24 version the labels' bug, is partially fixed.
Currently there is one label with description. Orca always reports "work offline button". 
Comment 9 Javier 2006-11-30 13:46:40 UTC
Created attachment 77419 [details]
Orca's script for better support Liferea application.

This script tries to address the issues in comment #1 and comment #3.
This has been tested with Liferea 1.0.23 (Ubuntu edgy eft) and the Liferea's gtkHTML browser.
Comment 10 Rich Burridge 2006-12-01 21:26:30 UTC
Created attachment 77512 [details] [review]
Revised version of the patch.

Hi Javier.

Thanks for your patch. I reworked it to:

- Remove Control-M's.
- Add the id/version/date/copyright/license section.
- Adjust to the "standard" indentation and spacing we are using with the 
  Orca project.
- Adjust the comments to read better.
- Add in an .../orca/src/orca/scripts/Makefile.am entry for this new script.

Unfortunately the script doesn't want to work for me. This is with testing
it against liferea v1.0.23 on Ubuntu Edgy.

The problem is that the default installation of liferea as installed
through the Synaptic Package manager is built with the Gecko HTML
rendering engine. What's happening is that accessibility events for this
application are showing up in Orca looking like:

vvvvv PROCESS OBJECT EVENT window:activate vvvvv
OBJECT EVENT: window:activate                          detail=(0,0)
    app.name='Firefox'            name='Liferea' role='frame' state='ACTIVE ENABLED RESIZABLE SENSITIVE SHOWING VISIBLE' relations=''
Looking for script at orca-scripts.Firefox.py...
...could not find orca-scripts.Firefox.py
Looking for script at scripts.Firefox.py...
...could not find scripts.Firefox.py
NEW SCRIPT: Firefox (module=orca.default)
ACTIVE SCRIPT: Firefox (module=orca.default)

Notice that the app.name is Firefox. Orca looks for a Firefox.py
script. There isn't one, so it defaults to using default.py.

If I make the following change to settings.py:

Index: settings.py
===================================================================
RCS file: /cvs/gnome/orca/src/orca/settings.py,v
retrieving revision 1.91
diff -u -r1.91 settings.py
--- settings.py 30 Nov 2006 16:38:58 -0000      1.91
+++ settings.py 1 Dec 2006 21:17:46 -0000
@@ -527,3 +527,4 @@
 setScriptMapping(re.compile(_('bug-buddy')), "gnome_segv2")
 setScriptMapping(re.compile(_('vte')), "gnome-terminal")
 setScriptMapping(re.compile(_('time-admin')), "users-admin")
+setScriptMapping(re.compile(_('Firefox')), "Liferea")

to map the "Firefox" application to the Liferea script, ir now picks up
your script. This change seems bogus to me though.

Even now, it's not fully working. The online/offline button is nicely
reported, but if focus is on one of the column headers in the headings
table, I still can't get it to move into that table. If I give focus to
one of the entries in that table, it's not being spoken.

I think this still needs a little more work before it can be checked in.
Comment 11 Javier 2007-01-03 10:20:02 UTC
Created attachment 79259 [details] [review]
Reworked patch

This new revision changes the script name Liferea.py now is liferea.py.

P.S.: This bug commit is sent with firefox browser and orca (blindly)
Comment 12 Javier 2007-01-03 10:24:02 UTC
The patch in comment #11 work for me using Liferea 1.0.23 and liferea-gtkhtml engine.
Comment 13 Rich Burridge 2007-01-03 18:39:34 UTC
Yup. Will showed me that you can install liferea-gtkhtml
and then use Program->Preferences to change it to use the
gtk html engine to render the posts.

I'm going to check your patch in, in a few minutes. Thanks.
Comment 14 Rich Burridge 2007-01-03 18:53:36 UTC
Changes checked into SVN trunk. Removing "blocked" status
as the underlying problems have been closed (one
was fixed the other closed as "will not fix").

Closing this bug as FIXED. Thanks Javier!