After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350212 - Spin Buttons only announce one change.
Spin Buttons only announce one change.
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
0.2.x
Other All
: Normal normal
: ---
Assigned To: Rich Burridge
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-07 01:30 UTC by Rich Burridge
Modified: 2006-08-08 19:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Patch to hopefully fix the problem. (1.18 KB, patch)
2006-08-08 16:27 UTC, Rich Burridge
none Details | Review

Description Rich Burridge 2006-08-07 01:30:53 UTC
Look at gnome-terminal prefs spin buttons - up and down arrow to 
change the value.  Note that it brailles all changes, but doesn't 
speak them.

[Tested by Will with the CVS equivalent of Orca 0.2.8 on Ubuntu 
Dapper Drake v6.06].
Comment 1 Willie Walker 2006-08-07 12:23:06 UTC
This is definitely a bug.
Comment 2 Rich Burridge 2006-08-08 15:56:29 UTC
The initial:
SPEECH OUTPUT: '1000 spin button'
is the result of a "focus:" event.

After that, there is an
"object:text-caret-moved" event, which causes:
SPEECH OUTPUT: '1001'
to be spoken.

From then on, we get pairs of "object:text-changed:delete"
and "object:text-changed:insert" events.

What it looks like we can do is add some code to
onTextInserted() in default.py to check to see if the
role of the event.source object is a "spin button".
If it is, then always speak the text.
Comment 3 Rich Burridge 2006-08-08 16:27:07 UTC
Created attachment 70498 [details] [review]
Patch to hopefully fix the problem.

This patch seems to nicely speak the text in a spin
button as you Up/Down arrow to change it's value. It
has the side-effect of speaking the first change twice:
once for the "object:text-caret-moved" event and then
again for the "object:text-changed:insert" event. 

Could somebody try this out and see if it's what we want?  Thanks.
Comment 4 Rich Burridge 2006-08-08 19:35:18 UTC
Talked this over with Will Patch looks okay.
Checked into CVS HEAD. Closing as FIXED.