GNOME Bugzilla – Bug 350053
keyword search doesn't work with trunk
Last modified: 2006-12-04 19:16:19 UTC
Typing search terms into location entry used to do a google search (keyword.URL), but doesn't anymore using gecko trunk. See https://bugzilla.mozilla.org/show_bug.cgi?id=336017 and https://bugzilla.mozilla.org/show_bug.cgi?id=332668.
<useless comment> Ahhhh <o> <o>. I need this!!!!. </useless comment> Both bugs seem resolved, maybe Edgy is still out dated?
*** Bug 355690 has been marked as a duplicate of this bug. ***
*** Bug 356040 has been marked as a duplicate of this bug. ***
*** Bug 356012 has been marked as a duplicate of this bug. ***
major regression imho.
Agreed. Makes me swear out loud everytime I use epiphany in edgy and retype entirely my query to paste it into google (because epiphany clears the location bar when your entry is invalid!!). From what I understand, it's supposedly fixed here but it's an ubuntu issue? Or does this affect other distros?
I share your pain.
If it's an Ubuntu issue here is an Ubuntu bug: https://launchpad.net/distros/ubuntu/+source/epiphany-browser/+bug/60691
(In reply to comment #6) > Agreed. Makes me swear out loud everytime I use epiphany in edgy and retype > entirely my query to paste it into google (because epiphany clears the location > bar when your entry is invalid!!). O know what you mean. I've noticed though that you don't necessarily have to retype everything; switching to a new tab and back wil show the text again, so you can add another space and use a smart bookmark, or copy it to the clipboard.
The solution would be to add a flag to ephy_embed_load_url that if set adds nsIWebNavigation::LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP to the load flags and implement a replacement for gtK_moz_embed_load_url of course since that doesn't allow passing load flags (and only set that flag when loading the location entry's address).
*** Bug 358195 has been marked as a duplicate of this bug. ***
chpe: Can you please add a "LOAD_FLASH_ALLOW_THIRD_PARTY_FIXUP fix for dummies" comment? Sounds simple enough to give it a try but a for dummies explanation would help :).
dieguito: jfr is working on a patch.
*** Bug 337109 has been marked as a duplicate of this bug. ***
Cool.
*** Bug 360077 has been marked as a duplicate of this bug. ***
*** Bug 360404 has been marked as a duplicate of this bug. ***
Ubuntu won't update until the status of this bug has changed. Has this issue been resolved in trunk?
Created attachment 75156 [details] [review] get keyword search back The patch adds bits to pass referrer too => only for test atm (do not apply on your preferred epiphany).
[ephy-shell.c] + ephy_embed_load (embed, url, load_flags, previous_embed); Please make this NULL for last param (no referrer for now) and check it in on gnome-2-16 and HEAD?
Ok, the keyword search is back on trunk: 2006-10-22 Jean-François Rameau <jframeau@cvs.gnome.org> * embed/ephy-embed.h: * embed/ephy-embed.c: * embed/mozilla/EphyBrowser.cpp: * embed/mozilla/EphyBrowser.h: * embed/mozilla/mozilla-embed.cpp: * src/ephy-link.h: * src/ephy-location-action.c: (action_activated_cb): * src/ephy-shell.c: (ephy_shell_new_tab_full): * src/ephy-shell.h: * src/ephy-window.c: (ephy_window_open_link): Get keyword search back by passing ALLOW_THIRD_PARTY_FIXUP flag to gecko. Add a new load method to EphyEmbed to custom load behaviour and pass (optional) referrer. Fix bug #350053. I'm preparing the patch to 2.16 branch (should be straightforward).
*** Bug 368057 has been marked as a duplicate of this bug. ***
So, can this bug be marked FIXED?
The backported fix isn't in gnome-2-16 yet so it should probably wait.
I just tried the patch on 2.16.1 and it applied fine and also fixed this issue.
True. Patch applied to gnome-2.16 branch. 2006-11-05 Jean-François Rameau <jframeau@cvs.gnome.org> * embed/ephy-embed.h: * embed/ephy-embed.c: * embed/mozilla/EphyBrowser.cpp: * embed/mozilla/EphyBrowser.h: * embed/mozilla/mozilla-embed.cpp: * src/ephy-link.h: * src/ephy-location-action.c: (action_activated_cb): * src/ephy-shell.c: (ephy_shell_new_tab_full): * src/ephy-shell.h: * src/ephy-window.c: (ephy_window_open_link): Get keyword search back by passing ALLOW_THIRD_PARTY_FIXUP flag to gecko. Add a new load method to EphyEmbed to custom load behaviour and pass (optional) referrer. Fix bug #350053. So closing the bug :)