After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350053 - keyword search doesn't work with trunk
keyword search doesn't work with trunk
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: [obsolete] Backend:Mozilla
2.16.x
Other Linux
: Normal normal
: 2.16.x
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
: 337109 355690 356012 356040 358195 360077 360404 368057 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-08-05 11:44 UTC by Christian Persch
Modified: 2006-12-04 19:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
get keyword search back (10.57 KB, patch)
2006-10-21 21:26 UTC, Jean-François Rameau
accepted-commit_now Details | Review

Description Christian Persch 2006-08-05 11:44:01 UTC
Typing search terms into location entry used to do a google search (keyword.URL), but doesn't anymore using gecko trunk.

See https://bugzilla.mozilla.org/show_bug.cgi?id=336017 and https://bugzilla.mozilla.org/show_bug.cgi?id=332668.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2006-08-24 01:38:29 UTC
<useless comment>
Ahhhh <o> <o>.
I need this!!!!.
</useless comment>

Both bugs seem resolved, maybe Edgy is still out dated?
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2006-09-13 01:27:36 UTC
*** Bug 355690 has been marked as a duplicate of this bug. ***
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2006-09-15 02:12:01 UTC
*** Bug 356040 has been marked as a duplicate of this bug. ***
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2006-09-15 02:12:31 UTC
*** Bug 356012 has been marked as a duplicate of this bug. ***
Comment 5 Reinout van Schouwen 2006-09-15 07:56:33 UTC
major regression imho.
Comment 6 Jean-François Fortin Tam 2006-09-15 20:13:21 UTC
Agreed. Makes me swear out loud everytime I use epiphany in edgy and retype entirely my query to paste it into google (because epiphany clears the location bar when your entry is invalid!!).

From what I understand, it's supposedly fixed here but it's an ubuntu issue? Or does this affect other distros?
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2006-09-15 21:26:36 UTC
I share your pain.
Comment 8 Quim Gil 2006-09-16 09:30:30 UTC
If it's an Ubuntu issue here is an Ubuntu bug: https://launchpad.net/distros/ubuntu/+source/epiphany-browser/+bug/60691
Comment 9 Christoph Wolk 2006-09-16 14:01:18 UTC
(In reply to comment #6)
> Agreed. Makes me swear out loud everytime I use epiphany in edgy and retype
> entirely my query to paste it into google (because epiphany clears the location
> bar when your entry is invalid!!).

O know what you mean. I've noticed though that you don't necessarily have to retype everything; switching to a new tab and back wil show the text again, so you can add another space and use a smart bookmark, or copy it to the clipboard.
Comment 10 Christian Persch 2006-09-16 14:32:02 UTC
The solution would be to add a flag to ephy_embed_load_url that if set adds nsIWebNavigation::LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP to the load flags and implement a replacement for gtK_moz_embed_load_url of course since that doesn't allow passing load flags (and only set that flag when loading the location entry's address).
Comment 11 Reinout van Schouwen 2006-09-28 22:05:12 UTC
*** Bug 358195 has been marked as a duplicate of this bug. ***
Comment 12 Diego Escalante Urrelo (not reading bugmail) 2006-09-29 02:42:18 UTC
chpe:

Can you please add a "LOAD_FLASH_ALLOW_THIRD_PARTY_FIXUP fix for dummies" comment?

Sounds simple enough to give it a try but a for dummies explanation would help :).
Comment 13 Christian Persch 2006-09-29 11:52:01 UTC
dieguito: jfr is working on a patch.
Comment 14 Christian Persch 2006-09-29 19:34:42 UTC
*** Bug 337109 has been marked as a duplicate of this bug. ***
Comment 15 Diego Escalante Urrelo (not reading bugmail) 2006-09-29 23:41:20 UTC
Cool.
Comment 16 Diego Escalante Urrelo (not reading bugmail) 2006-10-06 05:31:11 UTC
*** Bug 360077 has been marked as a duplicate of this bug. ***
Comment 17 Diego Escalante Urrelo (not reading bugmail) 2006-10-07 20:28:05 UTC
*** Bug 360404 has been marked as a duplicate of this bug. ***
Comment 18 gbauman 2006-10-18 20:46:29 UTC
Ubuntu won't update until the status of this bug has changed. Has this issue been resolved in trunk?
Comment 19 Jean-François Rameau 2006-10-21 21:26:36 UTC
Created attachment 75156 [details] [review]
get keyword search back

The patch adds bits to pass referrer too => only for test atm (do not apply on your preferred epiphany).
Comment 20 Christian Persch 2006-10-21 21:31:26 UTC
[ephy-shell.c]
+		ephy_embed_load (embed, url, load_flags, previous_embed);

Please make this NULL for last param (no referrer for now) and check it in on gnome-2-16 and HEAD? 
Comment 21 Jean-François Rameau 2006-10-24 21:33:24 UTC
Ok, the keyword search is back on trunk:

2006-10-22  Jean-François Rameau  <jframeau@cvs.gnome.org>

	* embed/ephy-embed.h:
	* embed/ephy-embed.c:
	* embed/mozilla/EphyBrowser.cpp:
	* embed/mozilla/EphyBrowser.h:
	* embed/mozilla/mozilla-embed.cpp:
	* src/ephy-link.h:
	* src/ephy-location-action.c: (action_activated_cb):
	* src/ephy-shell.c: (ephy_shell_new_tab_full):
	* src/ephy-shell.h:
	* src/ephy-window.c: (ephy_window_open_link):

	Get keyword search back by passing ALLOW_THIRD_PARTY_FIXUP flag to gecko.
	Add a new load method to EphyEmbed to custom load behaviour and pass (optional) referrer.
	Fix bug #350053.

I'm preparing the patch to 2.16 branch (should be straightforward).
Comment 22 Diego Escalante Urrelo (not reading bugmail) 2006-10-31 03:11:00 UTC
*** Bug 368057 has been marked as a duplicate of this bug. ***
Comment 23 Wouter Bolsterlee (uws) 2006-11-02 23:23:25 UTC
So, can this bug be marked FIXED?
Comment 24 Allison Karlitskaya (desrt) 2006-11-02 23:54:18 UTC
The backported fix isn't in gnome-2-16 yet so it should probably wait.
Comment 25 Priit Laes (IRC: plaes) 2006-11-07 17:51:34 UTC
I just tried the patch on 2.16.1 and it applied fine and also fixed this issue.
Comment 26 Jean-François Rameau 2006-11-08 20:44:49 UTC
True. Patch applied to gnome-2.16 branch.

2006-11-05  Jean-François Rameau  <jframeau@cvs.gnome.org>

	* embed/ephy-embed.h:
	* embed/ephy-embed.c:
	* embed/mozilla/EphyBrowser.cpp:
	* embed/mozilla/EphyBrowser.h:
	* embed/mozilla/mozilla-embed.cpp:
	* src/ephy-link.h:
	* src/ephy-location-action.c: (action_activated_cb):
	* src/ephy-shell.c: (ephy_shell_new_tab_full):
	* src/ephy-shell.h:
	* src/ephy-window.c: (ephy_window_open_link):

	Get keyword search back by passing ALLOW_THIRD_PARTY_FIXUP flag to gecko.
	Add a new load method to EphyEmbed to custom load behaviour and pass (optional) referrer.
	Fix bug #350053.

So closing the bug :)