After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349961 - clean up background setting code
clean up background setting code
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
0.x.x [obsolete]
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-04 17:06 UTC by Matthias Clasen
Modified: 2006-08-08 14:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the patch (2.44 KB, patch)
2006-08-04 17:07 UTC, Matthias Clasen
none Details | Review

Description Matthias Clasen 2006-08-04 17:06:38 UTC
initialize_background_from_settings unnecessarily returns a changed boolean,
and compares the values itself to obtain that information. This is unnecessary,
since EelBackground already does the same. Also, by letting eel do this comparison, we can make it smarter and reload changed background images, even
if the image uri has not changed (this is a problem at the moment with the
firefox "Set as Desktop background" feature, which always writes the same file 
"Firefox_wallpaper.png").
Comment 1 Matthias Clasen 2006-08-04 17:07:41 UTC
Created attachment 70208 [details] [review]
the patch
Comment 2 Matthias Clasen 2006-08-04 17:10:02 UTC
See also bug 349962
Comment 3 Alexander Larsson 2006-08-08 14:10:58 UTC
Commited. Thanks.