GNOME Bugzilla – Bug 349943
[QOS] documentation/code mismatch
Last modified: 2006-08-11 13:12:03 UTC
part-qos.txt mentions Jitter as being negative when the buffer arrived late and positive if it arrived in time. It also mentions that : Using the jitter we can calculate the time when the buffer arrived in the sink: T1 = B1 - J1. (1) The time the buffer leaves the sink after synchronisation is measured as: T2 = B1 - (J1 < 0 ? J1 : 0) (2) When Basesink code does it the other way around : /* this is the time the buffer entered the sink */ entered = start + jitter; /* this is the time the buffer left the sink */ left = start + (jitter < 0 ? 0 : jitter);
* docs/design/part-qos.txt: Bring docs in line with the code. Mostly the sign of the jitter was wrong in the docs. Fixes #349943. * gst/gstclock.c: Fix the docs for the jitter. * gst/gstevent.c: (gst_event_new_custom), (gst_event_new_tag), (gst_event_parse_tag), (gst_event_new_buffer_size), (gst_event_parse_buffer_size), (gst_event_parse_qos), (gst_event_new_seek), (gst_event_parse_seek), (gst_event_new_navigation): Make sure the GstStructure has no parent when creating custom events. Add some more argument checking so that we avoid 0.0 rates. Flesh out the docs for the QoS event some more.