After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349726 - EContactPhoto API break (eds 1.8) breaks gpm
EContactPhoto API break (eds 1.8) breaks gpm
Status: RESOLVED FIXED
Product: contact-lookup-applet
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Contact-lookup-applet Maintainers
Contact-lookup-applet Maintainers
: 351186 351942 352792 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-08-02 22:40 UTC by Ed Catmur
Modified: 2006-10-16 23:32 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
349726-EContactPhoto.patch (798 bytes, patch)
2006-08-02 22:42 UTC, Ed Catmur 		none Details | Review
349726-EContactPhoto.patch (1.28 KB, patch)
2006-08-02 23:11 UTC, Ed Catmur 		none Details | Review
349726-EContactPhoto-cla.patch (1.11 KB, patch)
2006-08-03 13:14 UTC, Ed Catmur 		none Details | Review
349726-EContactPhoto-cla.patch (2.60 KB, patch)
2006-08-03 13:29 UTC, Ed Catmur 		accepted-commit_now Details | Review
349726-EContactPhoto-gpm.patch (1.60 KB, patch)
2006-08-03 13:30 UTC, Ed Catmur 		none Details | Review
349726-EContactPhoto-cla.patch (2.64 KB, patch)
2006-08-21 16:11 UTC, Ed Catmur 		none Details | Review
349726-EContactPhoto-gpm.patch (1.63 KB, patch)
2006-08-21 16:12 UTC, Ed Catmur 		none Details | Review
349726-EContactPhoto-gpm.patch (1.63 KB, patch)
2006-08-21 16:17 UTC, Ed Catmur 		none Details | Review
349726-EContactPhoto-cla.patch (2.65 KB, patch)
2006-08-21 16:57 UTC, Ed Catmur 		committed Details | Review
349726-EContactPhoto-gpm.patch (1.63 KB, patch)
2006-08-21 16:58 UTC, Ed Catmur 		committed Details | Review

Description Ed Catmur 2006-08-02 22:40:27 UTC 
e-contact-entry.c: In function ‘view_contacts_added_cb’:
e-contact-entry.c:258: error: cannot convert to a pointer type
e-contact-entry.c:259: error: ‘EContactPhoto’ has no member named ‘length’
make[2]: *** [e-contact-entry.o] Error 1
make[2]: Leaving directory `/var/tmp/portage/gnome-phone-manager-0.7/work/gnome-phone-manager-0.7/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/gnome-phone-manager-0.7/work/gnome-phone-manager-0.7'
make: *** [all] Error 2
Comment 1 Ed Catmur 2006-08-02 22:42:13 UTC 
Created attachment 70098 [details] [review]
349726-EContactPhoto.patch

Basic patch
Comment 2 Ed Catmur 2006-08-02 23:11:14 UTC 
Created attachment 70100 [details] [review]
349726-EContactPhoto.patch

version-aware patch
Comment 3 Ed Catmur 2006-08-02 23:16:46 UTC 
fwiw, the API break in question is bug 313533.
Comment 4 Bastien Nocera 2006-08-03 07:52:55 UTC 
That actually needs to be fix in contact-lookup-applet and sync'ed in gnome-phone-manager afterwards. Ross?
Comment 5 Ed Catmur 2006-08-03 13:14:01 UTC 
Created attachment 70131 [details] [review]
349726-EContactPhoto-cla.patch

k
Comment 6 Ed Catmur 2006-08-03 13:29:41 UTC 
Created attachment 70133 [details] [review]
349726-EContactPhoto-cla.patch

oops, forgot that file.
Comment 7 Ed Catmur 2006-08-03 13:30:19 UTC 
Created attachment 70134 [details] [review]
349726-EContactPhoto-gpm.patch

fix leak
Comment 8 Bastien Nocera 2006-08-20 22:09:40 UTC 
*** Bug 351942 has been marked as a duplicate of this bug. ***
Comment 9 Bastien Nocera 2006-08-20 22:11:05 UTC 
Ross, does that look OK for you?
Comment 10 Ross Burton 2006-08-21 07:08:33 UTC 
Ideally the check would work on the existence of a data type introduced by the new API (the enum?) as there is talk of reverting the change...

The code looks good though so feel free to commit to c-l-a.
Comment 11 Ed Catmur 2006-08-21 16:11:37 UTC 
Created attachment 71313 [details] [review]
349726-EContactPhoto-cla.patch
Comment 12 Ed Catmur 2006-08-21 16:12:14 UTC 
Created attachment 71315 [details] [review]
349726-EContactPhoto-gpm.patch
Comment 13 Ed Catmur 2006-08-21 16:12:39 UTC 
(In reply to comment #10)
> Ideally the check would work on the existence of a data type introduced by the
> new API (the enum?) as there is talk of reverting the change...

Like this?
Comment 14 Ed Catmur 2006-08-21 16:17:18 UTC 
Created attachment 71316 [details] [review]
349726-EContactPhoto-gpm.patch

correct CFLAGS var
Comment 15 Ross Burton 2006-08-21 16:23:32 UTC 
Looks reasonable to me.
Comment 16 Ed Catmur 2006-08-21 16:57:38 UTC 
Created attachment 71319 [details] [review]
349726-EContactPhoto-cla.patch
Comment 17 Ed Catmur 2006-08-21 16:58:06 UTC 
Created attachment 71320 [details] [review]
349726-EContactPhoto-gpm.patch

Use CPPFLAGS for robustness against AC_LANG
Comment 18 Bastien Nocera 2006-08-22 18:26:44 UTC 
Committed to c-l-a:

2006-08-22  Bastien Nocera  <hadess@hadess.net>

        * configure.ac:
        * src/contact-dialog.c:
        * src/e-contact-entry.c: Patch from Ed Catmur <ed@catmur.co.uk>
        to make c-l-a compile with newer versions of e-d-s (Closes: #349726)

and g-p-m:

2006-08-22  Bastien Nocera  <hadess@hadess.net>

        * configure.in:
        * src/e-contact-entry.c: Patch from Ed Catmur <ed@catmur.co.uk>
        to make c-l-a compile with newer versions of e-d-s (Closes: #349726)
Comment 19 Bastien Nocera 2006-08-25 10:20:35 UTC 
*** Bug 352792 has been marked as a duplicate of this bug. ***
Comment 20 Brian Pepple 2006-10-16 23:32:10 UTC 
*** Bug 351186 has been marked as a duplicate of this bug. ***