After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349656 - jitterbuffer in GstBaseRtp fails to handle rtp seqnum rollover
jitterbuffer in GstBaseRtp fails to handle rtp seqnum rollover
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.x
Other Linux
: Normal normal
: 0.10.10
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-02 11:16 UTC by Marcel Moreaux
Modified: 2006-08-02 17:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
The patch fixing both issues (1.49 KB, patch)
2006-08-02 11:17 UTC, Marcel Moreaux 		committed Details | Review

Description Marcel Moreaux 2006-08-02 11:16:39 UTC 
RTP uses a 16bit monotonically increasing sequence number for packet ordering. Because this counter is small, it rolls over fairly quickly, but the GstBaseRtp class does not handle this correctly (it always orders lower sequence numbers as being earlier).

Also, this jitterbuffer in GstBaseRtp is enabled by default. When discussing this issue with the GstBaseRtp author/maintainer, he said that it shouldn't be enabled by default.

A patch that fixes both issues follows.
Comment 1 Marcel Moreaux 2006-08-02 11:17:47 UTC 
Created attachment 70066 [details] [review]
The patch fixing both issues
Comment 2 Wim Taymans 2006-08-02 17:06:20 UTC 
        Patch by: Marcel Moreaux <marcelm at luon dot net>

        * gst-libs/gst/rtp/gstbasertpdepayload.c:
        (gst_base_rtp_depayload_add_to_queue):
        * gst-libs/gst/rtp/gstbasertpdepayload.h:
        Handle RTP sequence number rollover.
        Disable jitterbuffer by default.