After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349650 - Gtk::FontButton(const Glib::ustring&) constructor does not work
Gtk::FontButton(const Glib::ustring&) constructor does not work
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: general
2.9.x
Other All
: Normal minor
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2006-08-02 10:11 UTC by Armin Burgmeier
Modified: 2006-08-02 16:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Proposed patch (2.82 KB, patch)
2006-08-02 10:13 UTC, Armin Burgmeier
none Details | Review

Description Armin Burgmeier 2006-08-02 10:11:47 UTC
Please describe the problem:
The constructor tries to set the property "fontname" of the button, but the correct property name is "font-name".

Steps to reproduce:
1. Call the Gtk::FontButton constructor with a font name as argument.

Actual results:
It prints a warning that says that there is no "fontname" property in GtkFontButton and does not set the correct font but stil displays the default "Sans 12".

Expected results:
It should initialize the button with the given font.

Does this happen every time?
Yes.

Other information:
Comment 1 Armin Burgmeier 2006-08-02 10:13:15 UTC
Created attachment 70064 [details] [review]
Proposed patch

The patch renames the argument in Gtk::FontButton::FontButton to font_name which causes gmmproc to generate the correct property name.
Comment 2 Murray Cumming 2006-08-02 10:38:23 UTC
Excellent. Someone should commit this.
Comment 3 Jonathon Jongsma 2006-08-02 14:55:19 UTC
I've committed it to HEAD, gtkmm-2-8, and gtkmm-2-6.  Do I need to go back to 2-4 as well?
Comment 4 Murray Cumming 2006-08-02 16:23:50 UTC
No, don't worry. We can do that if somebody needs it. Many thanks for the multiple-comitting work.