After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349556 - [PATCH] Little bug makes gThumb slower than it can be
[PATCH] Little bug makes gThumb slower than it can be
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2006-08-01 16:18 UTC by Colin Leroy
Modified: 2006-08-17 16:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes described bug (887 bytes, patch)
2006-08-01 16:19 UTC, Colin Leroy 		none Details | Review

Description Colin Leroy 2006-08-01 16:18:44 UTC 
Hi,

The preloader code seems to have a little bug: even though VFS priority is set to MAX for the requested image and to MIN for the next and previous one, the gnome_vfs_async_get_file_info is done with NORMAL priority everytime, thus slowing down the loading of the requested image.

Also, there are 4 preloaders defined, probably dating back from the days gThumb preloaded images N, N-1, N+1 and N+2. I think getting rid of the fourth one can just spare some resources, and not slow down anything.

Patch upcoming...
Comment 1 Colin Leroy 2006-08-01 16:19:23 UTC 
Created attachment 70036 [details] [review]
Fixes described bug
Comment 2 Paolo Bacchilega 2006-08-17 16:17:06 UTC 
patch applied, thanks.